Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing build with Ember beta and canary #4543

Closed
wants to merge 1 commit into from

Conversation

bmac
Copy link
Member

@bmac bmac commented Sep 21, 2016

It looks like something changed with the recent Ember beta that caused values that are provided to Ember.Object.create() to get stored on meta and cleared out when the object is destroyed.

Ember Data was injecting _internalModel into the model when its created here. On Ember 2.8.0 the _internalModel property was still available after the model was destroyed. In the Ember 2.9.0-beta.3 record._internalModel is no longer accessible after a record has been destroyed.

cc @rwjblue @stefanpenner

@rwjblue
Copy link
Member

rwjblue commented Sep 22, 2016

#4545 also fixes

@bmac bmac closed this Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants