Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify the RecordArray once it has been loaded from Server #374

Closed
wants to merge 1 commit into from
Closed

Notify the RecordArray once it has been loaded from Server #374

wants to merge 1 commit into from

Conversation

bradleypriest
Copy link
Member

I couldn't find an existing way to determine whether the server had responded to a findAll call.
At the moment I can't distinguish between a RecordArray that hasn't been responded to and one that has come back with a response of no records.

Thoughts? Am I missing something?

@travisbot
Copy link

This pull request fails (merged 61cd16a into dad611c).

@tchak
Copy link
Member

tchak commented Sep 6, 2012

Here is my take on the same issue #377

@bradleypriest
Copy link
Member Author

@tchak I think #377 is solving a different problem. I just want to know whether the adapter has received a response yet so I can distinguish whether I have an unloaded array or a loaded empty array. Although with your PR it should be easier to implement.

@tchak
Copy link
Member

tchak commented Sep 7, 2012

@bradleypriest in my PR findAll returns an DS.AdapterPopulatedRecordArray witch have a isLoaded property. all returns a live query (like findAll now) wich should not have isLoaded property as it do not load :)

@bradleypriest
Copy link
Member Author

Oh whoops, I thought you'd created a new type of Array. Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants