Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and deprecate finders (store.all -> store.peekAll and store.getById -> store.peekRecord) #3209

Merged
merged 2 commits into from
Jun 10, 2015
Merged

Rename and deprecate finders (store.all -> store.peekAll and store.getById -> store.peekRecord) #3209

merged 2 commits into from
Jun 10, 2015

Conversation

HeroicEric
Copy link
Member

closes #3205

@HeroicEric HeroicEric force-pushed the rename-store-finders branch 2 times, most recently from db90567 to bbcdd84 Compare June 6, 2015 17:06
@bmac
Copy link
Member

bmac commented Jun 6, 2015

Hi @HeroicEric. Now the consensus is peekById should be renamed to peekRecord. Do you mind updating this pr to reflect that change?

Thanks and sorry about making you redo some of this work.

@HeroicEric
Copy link
Member Author

@bmac sure

@HeroicEric
Copy link
Member Author

@bmac do you have a link to that discussion?

@HeroicEric HeroicEric force-pushed the rename-store-finders branch from bbcdd84 to 2568997 Compare June 6, 2015 18:01
@HeroicEric HeroicEric changed the title Rename and deprecate finders (store.all -> store.peekAll and store.getById -> store.peekById) Rename and deprecate finders (store.all -> store.peekAll and store.getById -> store.peekRecord) Jun 6, 2015
@bmac
Copy link
Member

bmac commented Jun 6, 2015

@HeroicEric emberjs/rfcs#27 (comment)

@HeroicEric HeroicEric force-pushed the rename-store-finders branch from 2568997 to 64720d4 Compare June 6, 2015 22:46
@HeroicEric HeroicEric mentioned this pull request Jun 7, 2015
Merged
3 tasks
@HeroicEric HeroicEric force-pushed the rename-store-finders branch 2 times, most recently from 3d4939b to cec9daa Compare June 8, 2015 19:27
@HeroicEric
Copy link
Member Author

@bmac this should be good to go now. I updated the guides too emberjs/guides#346

@HeroicEric HeroicEric force-pushed the rename-store-finders branch from cec9daa to 3f9b4b6 Compare June 10, 2015 05:10
bmac added a commit that referenced this pull request Jun 10, 2015
@bmac
Merge pull request #3209 from HeroicEric/rename-store-finders
d4f6050 
Rename and deprecate finders (store.all -> store.peekAll and store.getById -> store.peekRecord)
@bmac bmac merged commit d4f6050 into emberjs:master Jun 10, 2015
@bmac
Copy link
Member

bmac commented Jun 10, 2015

🎉

@HeroicEric HeroicEric deleted the rename-store-finders branch June 10, 2015 16:47
@sandstrom
Copy link
Contributor

Nice! This is very useful ⛵

bmac added a commit to bmac/data that referenced this pull request Jun 10, 2015
@bmac
Merge pull request emberjs#3209 from HeroicEric/rename-store-finders
12a8cca 
Rename and deprecate finders (store.all -> store.peekAll and store.getById -> store.peekRecord)
@HeroicEric HeroicEric mentioned this pull request Jun 12, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename and deprecate store.all/store.getById
3 participants
@HeroicEric @bmac @sandstrom