Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and deprecate store.all/store.getById #3205

Closed
bmac opened this issue Jun 5, 2015 · 1 comment · Fixed by #3209
Closed

Rename and deprecate store.all/store.getById #3205

bmac opened this issue Jun 5, 2015 · 1 comment · Fixed by #3209

Comments

@bmac
Copy link
Member

bmac commented Jun 5, 2015

store.getById should be renamed to peekById.

store.all should be renamed to store.peekAll.

For both of these methods we still need to support the old api with a deprecation warning recommending the use of the new name.

Docs and guides will also need to be updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bmac @HeroicEric