More rest adapter refactoring #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* didCreateRecords now take an array of records and json data for them * finished extracting callback methods for find requests * add didFindRecord in response to find request * find get passed record instance that it should pass to `didFindRecord`. It will allow us eventually to set loading record in error state. * add didFindQuery in response to recordArray based requests * findAll, findQuery and findMany all get passed recordArray instance that they should pass to store method `didFindQuery`. This allow a simpler and more uniform interface on the adapter. It will also eventually allow us to put recordArray in error state * in rest_adapter findAll and findMany are juste special cases of findQuery request
|
Most of this stuff is covered in #377 |
runspired
added
🏷️ feat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didFindRecord. It will allow us eventually to set loading record in error state.didFindQuery. This allow a simpler and more uniform interface on the adapter. It will also eventually allow us to put recordArray in error state