Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Non Strict Relationships #2093

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MichalBryxi
Copy link
Contributor

@MichalBryxi MichalBryxi commented Feb 4, 2025

TODO

  • Can someone check that I set inverse correctly (author blindness, can't guarantee)?
  • There was originally [this async: false], which I believe was incorrect. The JSON-API payload is using only IDs, so I would expect it to be async: true. Can someone confirm / deny?
  • All comments are resolved
  • Once the two above are checked, I can copy&paste the solution to all versions >= v5.0

- As per [ember-data:deprecate-non-strict-relationships](https://deprecations.emberjs.com/ember-data/v4.x/#toc_ember-data-deprecate-non-strict-relationships) we should update the guides to list all relationships explicitly.
- Supports ember-learn#1988
- Seems like we want most of the examples to be synchronous
- Supports: ember-learn#1988
Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit cb6e8b7
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/67a1bb1ec8e16800084cd739
😎 Deploy Preview https://deploy-preview-2093--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ember Data relationships guide has syntax that errors in 5.x
1 participant