Skip to content

Commit

Permalink
fix: { async: true } -> { async: false } for v5.0 ember-data
Browse files Browse the repository at this point in the history
- Seems like we want most of the examples to be synchronous
- Supports: #1988
  • Loading branch information
MichalBryxi committed Feb 4, 2025
1 parent fc4db08 commit cb6e8b7
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 18 deletions.
6 changes: 3 additions & 3 deletions guides/v5.0.0/models/customizing-serializers.md
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ a model:
import Model, { belongsTo } from '@ember-data/model';

export default class CommentModel extends Model {
@belongsTo('post', { async: false, inverse: 'comments' }) originalPost
@belongsTo('post', { async: true, inverse: 'comments' }) originalPost
}
```

Expand Down Expand Up @@ -713,8 +713,8 @@ import Model, { attr, hasMany } from '@ember-data/model';
export default class Post extends Model {
@attr('string') title;
@attr('string') tag;
@hasMany('comment', { async: false, inverse: 'post' }) comments;
@hasMany('post', { async: false, inverse: 'relatedPosts' }) relatedPosts;
@hasMany('comment', { async: true, inverse: 'post' }) comments;
@hasMany('post', { async: true, inverse: 'relatedPosts' }) relatedPosts;
}
```

Expand Down
30 changes: 15 additions & 15 deletions guides/v5.0.0/models/relationships.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ To declare a one-to-one relationship between two models, use
import Model, { belongsTo } from '@ember-data/model';

export default class UserModel extends Model {
@belongsTo('profile', { async: true, inverse: 'user' }) profile;
@belongsTo('profile', { async: false, inverse: 'user' }) profile;
}
```

```javascript {data-filename=app/models/profile.js}
import Model, { belongsTo } from '@ember-data/model';

export default class ProfileModel extends Model {
@belongsTo('user', { async: true, inverse: 'profile' }) user;
@belongsTo('user', { async: false, inverse: 'profile' }) user;
}
```

Expand All @@ -31,15 +31,15 @@ To declare a one-to-many relationship between two models, use
import Model, { hasMany } from '@ember-data/model';

export default class BlogPostModel extends Model {
@hasMany('comment', { async: true, inverse: 'blogPost' }) comments;
@hasMany('comment', { async: false, inverse: 'blogPost' }) comments;
}
```

```javascript {data-filename=app/models/comment.js}
import Model, { belongsTo } from '@ember-data/model';

export default class CommentModel extends Model {
@belongsTo('blog-post', { async: true, inverse: 'comments' }) blogPost;
@belongsTo('blog-post', { async: false, inverse: 'comments' }) blogPost;
}
```

Expand All @@ -52,15 +52,15 @@ To declare a many-to-many relationship between two models, use
import Model, { hasMany } from '@ember-data/model';

export default class BlogPostModel extends Model {
@hasMany('tag', { async: true, inverse: 'blogPosts' }) tags;
@hasMany('tag', { async: false, inverse: 'blogPosts' }) tags;
}
```

```javascript {data-filename=app/models/tag.js}
import Model, { hasMany } from '@ember-data/model';

export default class TagModel extends Model {
@hasMany('blog-post', { async: true, inverse: 'tags' }) blogPosts;
@hasMany('blog-post', { async: false, inverse: 'tags' }) blogPosts;
}
```

Expand All @@ -75,7 +75,7 @@ no inverse relationship exists, specify `{inverse: null }`.
import Model, { belongsTo } from '@ember-data/model';

export default class CommentModel extends Model {
@belongsTo('blog-post', { async: true, inverse: null }) blogPost;
@belongsTo('blog-post', { async: false, inverse: null }) blogPost;
}
```

Expand All @@ -97,8 +97,8 @@ Here's an example of a one-to-many reflexive relationship:
import Model, { belongsTo, hasMany } from '@ember-data/model';

export default class FolderModel extends Model {
@hasMany('folder', { async: true, inverse: 'parent' }) children;
@belongsTo('folder', { async: true, inverse: 'children' }) parent;
@hasMany('folder', { async: false, inverse: 'parent' }) children;
@belongsTo('folder', { async: false, inverse: 'children' }) parent;
}
```

Expand All @@ -109,7 +109,7 @@ import Model, { attr, belongsTo } from '@ember-data/model';

export default class UserModel extends Model {
@attr('string') name;
@belongsTo('user', { async: true, inverse: 'bestFriend' }) bestFriend;
@belongsTo('user', { async: false, inverse: 'bestFriend' }) bestFriend;
}
```

Expand All @@ -119,7 +119,7 @@ You can also define a reflexive relationship that doesn't have an inverse:
import Model, { belongsTo } from '@ember-data/model';

export default class FolderModel extends Model {
@belongsTo('folder', { async: true, inverse: null }) parent;
@belongsTo('folder', { async: false, inverse: null }) parent;
}
```

Expand All @@ -141,15 +141,15 @@ First, let's look at the model definitions:
import Model, { hasMany } from '@ember-data/model';

export default class UserModel extends Model {
@hasMany('payment-method', { async: true, inverse: 'user', polymorphic: true }) paymentMethods;
@hasMany('payment-method', { async: false, inverse: 'user', polymorphic: true }) paymentMethods;
}
```

```javascript {data-filename=app/models/payment-method.js}
import Model, { belongsTo } from '@ember-data/model';

export default class PaymentMethodModel extends Model {
@belongsTo('user', { async: true, inverse: 'paymentMethods' }) user;
@belongsTo('user', { async: false, inverse: 'paymentMethods' }) user;
}
```

Expand Down Expand Up @@ -262,15 +262,15 @@ Let's assume that we have a `blog-post` and a `comment` model. A single blog pos
import Model, { hasMany } from '@ember-data/model';

export default class BlogPostModel extends Model {
@hasMany('comment', { async: true, inverse: 'blogPost' }) comments;
@hasMany('comment', { async: false, inverse: 'blogPost' }) comments;
}
```

```javascript {data-filename=app/models/comment.js}
import Model, { belongsTo } from '@ember-data/model';

export default class CommentModel extends Model {
@belongsTo('blog-post', { async: true, inverse: 'comments' }) blogPost;
@belongsTo('blog-post', { async: false, inverse: 'comments' }) blogPost;
}
```

Expand Down

0 comments on commit cb6e8b7

Please sign in to comment.