Convert to a V2 addon and drop support for Ember < 3.28 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guidemaker-ember-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mansona
force-pushed
the
v2
branch
5 times, most recently
from
0c21f9a to
ebc0d0d
Compare
mansona
changed the title
mansona
force-pushed
the
v2
branch
2 times, most recently
from
412ffd1 to
eab7062
Compare
I ran ember init -b @embroider/addon-blueprint --pnpm
|
The callout images are not present, that seems unexpected? https://deploy-preview-188--guidemaker-ember-template.netlify.app/release/examples/callouts 
|
|
Images look all good now with the latest Embroider version! Only thing missing seems to be the icons: 
|
This was referenced May 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roughly speaking I ran
ember init -b @embroider/addon-blueprint --pnpmto get this far, and then did some tweakingSure this is a little extreme but it's at least possible so we should consider it (maybe) 😂