-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: highlight active title in "On This Page" #186
Conversation
✅ Deploy Preview for guidemaker-ember-template ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
OMG I LOVE IT! As this builds on the other PR I'm going to wait for that one before I merge 👍 |
bfdf974
to
7582eb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
I'm going to merge this as an enhancement because #188 is going to drop support for Ember < 3.28 and we can keep the breaking change there
Fixes #181
Builds on top of #184