Fix compatibility with ember-render-helpers v0.2 #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if we can get that compatibility test reliable. Overrides (and resolutions) are only supported at the root of the project. But as far as I know Ember Try does not support modifying the With the current setup it is coincidence if the ember-render-helpers version from the test-app or from ember-bootstrap package gets pulled into the build. |
….1 release with new helper names
jelhan
force-pushed
the
fix-compatibility-with-ember-render-helpers-v0.2
branch
from
5b8c767 to
7abc196
Compare
jelhan
changed the title
SanderKnauff
approved these changes
Nov 11, 2024
I think so. Conceptually they are the same as @ember/render-modifiers. I haven't looked into why we are using them to be honest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2156 should have restored compatibility with ember-render-helpers@^0.2.0 but it hasn't. The test had a bug and therefore leading to a false sense of security. The helpers were renamed in the v1.0 release and the new names weren't available in v0.2.0.
This PR requires ember-render-helpers v0.2.1 which backports the new helper names.
It removes the test as it was not working as expected anyways. See #2157 (comment) and ember-cli/ember-try#970 for context.