Widen support for ember-render-helpers to v1 #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanderKnauff
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for ember-render-helpers@^1.0.0 has been added in #2141 already. But accidentally support for ember-render-helpers@^0.2.0 has been dropped. We don't want that as it would make upgrading more complex for consumers. And may be considered a breaking change.
The change has not been released yet. So it is safe to just fix it before releasing.
Adding a changelog entry because there isn't one for #2141 yet.
I decided adding an additional ember-try scenario for ember-render-helpers@^0.2.0 because some code were changed on the upgrade as well.