Attempt to fix test on CI (again) #2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is failing on CI with this error: expected instance of: io.element.android.libraries.architecture.Async$Success but was instance of : io.element.android.libraries.architecture.Async$Loading with value : Loading(prevData=null)
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
jmartinesp
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2107 +/- ##
========================================
Coverage 67.47% 67.47%
========================================
Files 1364 1364
Lines 33881 33882 +1
Branches 7280 7280
========================================
+ Hits 22860 22861 +1
Misses 7563 7563
Partials 3458 3458 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2071 fixed issues with the testing flow. I reverted that when we had to downgrade the Rust SDK version before a release, but since we're seeing these same issues in
developnow maybe that was a mistake.