Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix test on CI. #2071

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Attempt to fix test on CI. #2071

merged 3 commits into from
Dec 20, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 20, 2023

No description provided.

@bmarty
Attempt to fix test on CI.
139f5cd 
The test is failing on CI with this error:
expected instance of: io.element.android.libraries.architecture.Async$Success
but was instance of : io.element.android.libraries.architecture.Async$Loading
with value          : Loading(prevData=null)
@bmarty bmarty requested a review from a team as a code owner December 20, 2023 08:16
@bmarty bmarty requested review from ganfra and removed request for a team December 20, 2023 08:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Km32ES

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0575c4d) 67.53% compared to head (258e074) 67.54%.
Report is 25 commits behind head on develop.

Files Patch % Lines
...eatures/roomlist/impl/components/RoomListTopBar.kt 0.00% 1 Missing and 1 partial ⚠️
...in/io/element/android/appconfig/AnalyticsConfig.kt 0.00% 1 Missing ⚠️
...lin/io/element/android/appconfig/RoomListConfig.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2071      +/-   ##
===========================================
+ Coverage    67.53%   67.54%   +0.01%     
===========================================
  Files         1357     1358       +1     
  Lines        33822    33814       -8     
  Branches      7274     7271       -3     
===========================================
  Hits         22841    22841              
+ Misses        7523     7515       -8     
  Partials      3458     3458

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 19edf06 into develop Dec 20, 2023
14 checks passed
@bmarty bmarty deleted the feature/bma/fixTests branch December 20, 2023 16:31
jmartinesp added a commit that referenced this pull request Dec 22, 2023
@jmartinesp
Revert "Merge pull request #2071 from element-hq/feature/bma/fixTests"
c5c920c 
This reverts commit 19edf06, reversing
changes made to fb766f5.
@jmartinesp jmartinesp mentioned this pull request Dec 22, 2023
Merged
@jmartinesp jmartinesp restored the feature/bma/fixTests branch December 26, 2023 07:24
@jmartinesp jmartinesp mentioned this pull request Dec 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

@ganfra ganfra Awaiting requested review from ganfra ganfra is a code owner automatically assigned from element-hq/element-x-android-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarty @jmartinesp