Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analytics issue. #2612

Closed
bmarty opened this issue Mar 27, 2024 · 0 comments · Fixed by #2618
Closed

Fix analytics issue. #2612

bmarty opened this issue Mar 27, 2024 · 0 comments · Fixed by #2618
Assignees
@bmarty

Comments

@bmarty
Copy link
Member

bmarty commented Mar 27, 2024 •
edited
Loading

This code:

        isSpace = MatrixPatterns.isSpaceId(this.roomId.value),

https://github.com/element-hq/element-x-android/blob/main/services/analytics/api/src/main/kotlin/io/element/android/services/analytics/api/extensions/ViewRoomExt.kt#L29

is not correct. isSpaceId returns true for all valid roomId, so the analytics are wrong.
@bmarty bmarty self-assigned this Mar 27, 2024
bmarty added a commit that referenced this issue Mar 28, 2024
@bmarty
Fix analytics: spaceId have the same syntax as roomId. Use MatrixRoom…
46008c2 
….isSpace instead of MatrixPatterns.isSpaceId (#2612)

Also remoce useless orFalse() calls.
@bmarty bmarty mentioned this issue Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix analytics element-hq/element-x-android
1 participant
@bmarty