Fix analytics: spaceId have the same syntax as roomId. Use MatrixRoom…

….isSpace instead of MatrixPatterns.isSpaceId (#2612) Also remoce useless orFalse() calls.
element-hq · Mar 28, 2024 · 46008c2 · 46008c2
1 parent ac9b74e
commit 46008c2
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 9 deletions.
diff --git a/changelog.d/2612.bugfix b/changelog.d/2612.bugfix
@@ -0,0 +1 @@
+Fix analytics issue around room considered as space by mistake.
diff --git a/...ies/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/MatrixRoom.kt b/...ies/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/MatrixRoom.kt
@@ -55,6 +55,7 @@ interface MatrixRoom : Closeable {
     val topic: String?
     val avatarUrl: String?
     val isEncrypted: Boolean
+    val isSpace: Boolean
     val isDirect: Boolean
     val isPublic: Boolean
     val activeMemberCount: Long

diff --git a/...trix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustMatrixRoom.kt b/...trix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/room/RustMatrixRoom.kt
@@ -213,6 +213,9 @@ class RustMatrixRoom(
     override val isPublic: Boolean
         get() = innerRoom.isPublic()
 
+    override val isSpace: Boolean
+        get() = innerRoom.isSpace()
+
     override val isDirect: Boolean
         get() = innerRoom.isDirect()
 

diff --git a/...trix/test/src/main/kotlin/io/element/android/libraries/matrix/test/room/FakeMatrixRoom.kt b/...trix/test/src/main/kotlin/io/element/android/libraries/matrix/test/room/FakeMatrixRoom.kt
@@ -77,6 +77,7 @@ class FakeMatrixRoom(
     override val alias: String? = null,
     override val alternativeAliases: List<String> = emptyList(),
     override val isPublic: Boolean = true,
+    override val isSpace: Boolean = false,
     override val isDirect: Boolean = false,
     override val isOneToOne: Boolean = false,
     override val joinedMemberCount: Long = 123L,

diff --git a/...api/src/main/kotlin/io/element/android/services/analytics/api/extensions/JoinedRoomExt.kt b/...api/src/main/kotlin/io/element/android/services/analytics/api/extensions/JoinedRoomExt.kt
@@ -17,8 +17,6 @@
 package io.element.android.services.analytics.api.extensions
 
 import im.vector.app.features.analytics.plan.JoinedRoom
-import io.element.android.libraries.core.bool.orFalse
-import io.element.android.libraries.matrix.api.core.MatrixPatterns
 import io.element.android.libraries.matrix.api.room.MatrixRoom
 
 fun Long?.toAnalyticsRoomSize(): JoinedRoom.RoomSize {
@@ -34,9 +32,9 @@ fun Long?.toAnalyticsRoomSize(): JoinedRoom.RoomSize {
 
 fun MatrixRoom.toAnalyticsJoinedRoom(trigger: JoinedRoom.Trigger?): JoinedRoom {
     return JoinedRoom(
-        isDM = this.isDirect.orFalse(),
-        isSpace = MatrixPatterns.isSpaceId(this.roomId.value),
-        roomSize = this.joinedMemberCount.toAnalyticsRoomSize(),
+        isDM = isDirect,
+        isSpace = isSpace,
+        roomSize = joinedMemberCount.toAnalyticsRoomSize(),
         trigger = trigger
     )
 }
diff --git a/...s/api/src/main/kotlin/io/element/android/services/analytics/api/extensions/ViewRoomExt.kt b/...s/api/src/main/kotlin/io/element/android/services/analytics/api/extensions/ViewRoomExt.kt
@@ -17,16 +17,14 @@
 package io.element.android.services.analytics.api.extensions
 
 import im.vector.app.features.analytics.plan.ViewRoom
-import io.element.android.libraries.core.bool.orFalse
-import io.element.android.libraries.matrix.api.core.MatrixPatterns
 import io.element.android.libraries.matrix.api.room.MatrixRoom
 
 fun MatrixRoom.toAnalyticsViewRoom(trigger: ViewRoom.Trigger? = null, selectedSpace: MatrixRoom? = null, viaKeyboard: Boolean? = null): ViewRoom {
     val activeSpace = selectedSpace?.toActiveSpace() ?: ViewRoom.ActiveSpace.Home
 
     return ViewRoom(
-        isDM = this.isDirect.orFalse(),
-        isSpace = MatrixPatterns.isSpaceId(this.roomId.value),
+        isDM = isDirect,
+        isSpace = isSpace,
         trigger = trigger,
         activeSpace = activeSpace,
         viaKeyboard = viaKeyboard
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix analytics issue around room considered as space by mistake.