Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

updated scripts / .ignores #30

Merged
merged 1 commit into from
May 13, 2015
Merged

updated scripts / .ignores #30

merged 1 commit into from
May 13, 2015

Conversation

RnbWd
Copy link
Contributor

@RnbWd RnbWd commented May 12, 2015

very useful

@RnbWd RnbWd mentioned this pull request May 12, 2015
max-mapper added a commit that referenced this pull request May 13, 2015
updated scripts / .ignores
@max-mapper max-mapper merged commit 36aa16e into electron-userland:master May 13, 2015
@max-mapper
Copy link
Contributor

thx

@mafintosh
Copy link
Collaborator

why is .npmignore needed?

@RnbWd
Copy link
Contributor Author

RnbWd commented May 13, 2015

I didn't realize that .gitignore was copied over to .npmignore until just now:

Use a .npmignore file to keep stuff out of your package. If there's no .npmignore file, but there is a .gitignore file, then npm will ignore the stuff matched by the .gitignore file. If you want to include something that is excluded by your .gitignore file, you can create an empty .npmignore file to override it.

It was just an (unnecessary in hindsight) precaution to prevent ~100 mb npm downloads accidently (if we published a repo with dist/)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants