This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
v0.26.0 #28
Closed
v0.26.0 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ | |||
| "scripts": { | |||
| "install": "node install.js", | |||
| "test": "tape test/*.js", | |||
| "cache-clean": "rimraf ~/.electron" | |||
There was a problem hiding this comment.
thats not a typo, its https://github.com/isaacs/rimraf. rm isn't cross platform, rimraf is
There was a problem hiding this comment.
the typo is referring to a previous commit before where I legit wrote a typo. But rimraf isn't in the package.json and ~/ isn't cross platform either :P
The scripts in this PR are decent (assuming mac/linux) #30
|
im gonna update 0.26.0 separately, as to not mix multiple concerns in one PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated electron-download in package.json