Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow skipLibCheck: false #8813

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

mmaietta
Copy link
Collaborator

Tasks:

  • Extract common undefined | null logic everywhere to reuse (now-exported) type Nullish
  • Expose FileMatcher by removing @internal flag (why was it internal to begin with?)
  • Created base type ObjectMap to reduce writing { [key: string]: <anything> } everywhere.
  • Updated eslint to register test/tsconfig.json
  • Fixes skipLibCheck: false by forcing UUID.ts to return a Buffer instead of Buffer<ArrayBuffer>, which the compiler doesn't like depending on version of node you're on

This should fix: #8812

…ed) type `Nullish`. Expose `FileMatcher` instead of `@internal` flag
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 7b356e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
app-builder-lib Patch
builder-util Patch
builder-util-runtime Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch
electron-publish Patch
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta mmaietta marked this pull request as ready for review January 27, 2025 21:55
@mmaietta mmaietta merged commit 0742966 into master Jan 27, 2025
15 checks passed
@mmaietta mmaietta deleted the chore/refactor-nullish-expose-FileMatcher branch January 27, 2025 22:26
@github-actions github-actions bot mentioned this pull request Jan 27, 2025
@t3chguy
Copy link
Contributor

t3chguy commented Jan 27, 2025

Created base type ObjectMap to reduce writing { [key: string]: } everywhere.

That sounds like Record<K, V>, no?

@mmaietta
Copy link
Collaborator Author

Haha yep, that is what I was looking for. Will swap that in

@mmaietta
Copy link
Collaborator Author

Turns out Record doesn't work with the scheme.json generator, but I'll find a middle ground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken types since v26
2 participants