Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken types since v26 #8812

Closed
t3chguy opened this issue Jan 27, 2025 · 5 comments · Fixed by #8813
Closed

Broken types since v26 #8812

t3chguy opened this issue Jan 27, 2025 · 5 comments · Fixed by #8813

Comments

@t3chguy
Copy link
Contributor

t3chguy commented Jan 27, 2025

Regressed by #8805

node_modules/app-builder-lib/out/asar/integrity.d.ts(2,10): error TS2305: Module '"../fileMatcher"' has no exported member 'FileMatcher'. https://github.com/electron-userland/electron-builder/blob/master/packages/app-builder-lib/src/fileMatcher.ts#L41 prevents the type from being included in the resulting types

@mmaietta
Copy link
Collaborator

Wait what, I'm not sure I follow. Is this a compile-time error with skipLibCheck: false? I'm trying to repro but can't seem to get the error. Not sure why @internal is flagging anything.

@t3chguy
Copy link
Contributor Author

t3chguy commented Jan 27, 2025

Wait what, I'm not sure I follow. Is this a compile-time error with skipLibCheck: false? I'm trying to repro but can't seem to get the error.

Yes it is that, for consumers of lib-app-builder anyway - such as myself needing computeData to rebuild asar integrity after a universal pkg.

Not sure why @internal is flagging anything.

@internal means the FileMatcher symbol is omitted from the output type, but asar/integrity.ts now imports and relies on that type in its method signature.

@t3chguy
Copy link
Contributor Author

t3chguy commented Jan 27, 2025

Looks great, will give it a test tomorrow. Thanks again

Or rather will await it shipping to npm

@mmaietta
Copy link
Collaborator

Deployed 26.0.1

@t3chguy
Copy link
Contributor Author

t3chguy commented Feb 2, 2025

Thanks @mmaietta can confirm that fixed it, and that the issues around asar integrity and electron fuses are both fixed in v26. Keep up the great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants