Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade xk6-output compatibility to v0.42.0 #3

Merged
merged 16 commits into from
Feb 9, 2023
Merged

Upgrade xk6-output compatibility to v0.42.0 #3

merged 16 commits into from
Feb 9, 2023

Conversation

selamanse
Copy link
Contributor

@selamanse selamanse commented Jan 20, 2023 •
edited
Loading

  • Upgrade depencies
  • Introduce internal metrics entry type mapping before serialization for elastic bulk
  • Add Dockerfile for containerization
  • Add custom workflow to push to internal registry

Closes #4

@cla-checker-service
Copy link

cla-checker-service bot commented Jan 20, 2023 •
edited
Loading

💚 CLA has been signed

@selamanse selamanse mentioned this pull request Jan 20, 2023
Closed
@selamanse
Copy link
Contributor Author

@danielmitterdorfer can you have a look at this change any time soon? I think it would be awesome to have this in the k6 catalog as working again.

danielmitterdorfer
danielmitterdorfer reviewed Feb 8, 2023
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and the ping @selamanse. I did not check the repo for updated PRs so I was not aware of it. IMHO the change is fine but I think the Docker image is not strictly in scope for this PR. Can you elaborate on its value? In any case, if we want to add a Docker image, we should do this in a separate PR. Would you mind removing the Docker-related changes from this PR?

@danielmitterdorfer danielmitterdorfer added the enhancement New feature or request label Feb 8, 2023
@selamanse
Copy link
Contributor Author

selamanse commented Feb 8, 2023 •
edited
Loading

@danielmitterdorfer I reverted the docker related additions but I left the main build for verification purposes which would execute the make and then zip the binary and upload it to the workflow run for review purposes... I think it might be helpful for future PRs.

@danielmitterdorfer danielmitterdorfer self-requested a review February 9, 2023 06:34
danielmitterdorfer
danielmitterdorfer approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround. The changes look fine to me now.

@danielmitterdorfer danielmitterdorfer merged commit d6baaeb into elastic:main Feb 9, 2023
danielmitterdorfer added a commit to danielmitterdorfer/xk6-output-elasticsearch that referenced this pull request Jan 9, 2024
@danielmitterdorfer
Write metrics tags only once to Elasticsearch
c90e714 
With this commit we remove the duplicate `MetricTags` and `SampleTags`
properties and replace them with a `Tags` property.

Relates elastic#3
Closes elastic#20
@danielmitterdorfer danielmitterdorfer mentioned this pull request Jan 9, 2024
Merged
danielmitterdorfer added a commit that referenced this pull request Jan 9, 2024
@danielmitterdorfer
Write metrics tags only once to Elasticsearch (#21)
96b5f69 
With this commit we remove the duplicate `MetricTags` and `SampleTags`
properties and replace them with a `Tags` property.

Relates #3
Closes #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make compatible to newer k6 version v0.42.0
2 participants
@selamanse @danielmitterdorfer