Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is the significance of SampleTags? Can they be filtered out? #20

Closed
abhisheksaraiya opened this issue Jan 4, 2024 · 2 comments · Fixed by #21
Closed

What is the significance of SampleTags? Can they be filtered out? #20

abhisheksaraiya opened this issue Jan 4, 2024 · 2 comments · Fixed by #21
Assignees
@danielmitterdorfer
Labels
bug Something isn't working

Comments

@abhisheksaraiya
Copy link

I see that the created index has MetricTags and SampleTags. What is the significance of SampleTags? Can we stop it from flowing to elastic?
@danielmitterdorfer
Copy link
Member

Thanks for the report. That might be a bug. I'll look into this soon.

@danielmitterdorfer danielmitterdorfer added the bug Something isn't working label Jan 9, 2024
@danielmitterdorfer danielmitterdorfer self-assigned this Jan 9, 2024
danielmitterdorfer added a commit to danielmitterdorfer/xk6-output-elasticsearch that referenced this issue Jan 9, 2024
@danielmitterdorfer
Write metrics tags only once to Elasticsearch
c90e714 
With this commit we remove the duplicate `MetricTags` and `SampleTags`
properties and replace them with a `Tags` property.

Relates elastic#3
Closes elastic#20
@danielmitterdorfer danielmitterdorfer mentioned this issue Jan 9, 2024
Merged
@danielmitterdorfer
Copy link
Member

This will be fixed by #21. I've also decided to simplify the name and renamed the property to Tags. So in the future MetricTags and SampleTags will be gone and the output will only write Tags.

danielmitterdorfer added a commit that referenced this issue Jan 9, 2024
@danielmitterdorfer
Write metrics tags only once to Elasticsearch (#21)
96b5f69 
With this commit we remove the duplicate `MetricTags` and `SampleTags`
properties and replace them with a `Tags` property.

Relates #3
Closes #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmitterdorfer danielmitterdorfer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Write metrics tags only once to Elasticsearch danielmitterdorfer/xk6-output-elasticsearch
2 participants
@danielmitterdorfer @abhisheksaraiya