Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thespian logs to ci #971

Merged
merged 3 commits into from
Apr 29, 2020
Merged

Add thespian logs to ci #971

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e053f3e
Add thespian logs to ci
hub-cap Apr 21, 2020
932a4ce
Merge remote-tracking branch 'upstream/master' into thespian_logs
hub-cap Apr 29, 2020
d3f4065
Simplify the variable check w/ a set command
hub-cap Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .ci/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,23 @@ set -e
set -o pipefail

function build {
if [[ ! -d ${RALLY_HOME} ]] ; then
echo "Rally home [${RALLY_HOME}] is not set or does not exist."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a conditional to check if the var is set, first, to help with troubleshooting?

e.g.

if [[ -z ${RALLY_HOME+x} ]]; then
    echo "Env var [RALLY_HOME] is unset."
    exit 1

Then the error message on this line can be clearer like:
echo "\$RALLY_HOME [${RALLY_HOME}] does not exist.

or something along those lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to eyeball this again. I went ahead and just removed the check, as rally will just create the directory if it does not exist, and I ensured its set with a set -u, and then changed it to set +u so the rest of the commands would work (IIRC it was pyenv that failed if set -u is set.

exit 1
fi

export PATH="$HOME/.pyenv/bin:$PATH"
export TERM=dumb
export LC_ALL=en_US.UTF-8
eval "$(pyenv init -)"
eval "$(pyenv virtualenv-init -)"

export THESPLOG_FILE="${THESPLOG_FILE:-${RALLY_HOME}/.rally/logs/actor-system-internal.log}"
# this value is in bytes, the default is 50kB. We increase it to 200kiB.
export THESPLOG_FILE_MAXSIZE=${THESPLOG_FILE_MAXSIZE:-204800}
# adjust the default log level from WARNING
export THESPLOG_THRESHOLD="INFO"

make prereq
make install
make precommit
Expand Down