Add thespian logs to ci #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hub-cap
added
enhancement
dliappis
reviewed
Apr 27, 2020
.ci/build.sh
Outdated
| @@ -23,11 +23,23 @@ set -e | |||
| set -o pipefail | |||
|
|
|||
| function build { | |||
| if [[ ! -d ${RALLY_HOME} ]] ; then | |||
| echo "Rally home [${RALLY_HOME}] is not set or does not exist." | |||
There was a problem hiding this comment.
What about adding a conditional to check if the var is set, first, to help with troubleshooting?
e.g.
if [[ -z ${RALLY_HOME+x} ]]; then
echo "Env var [RALLY_HOME] is unset."
exit 1
Then the error message on this line can be clearer like:
echo "\$RALLY_HOME [${RALLY_HOME}] does not exist.
or something along those lines?
There was a problem hiding this comment.
You might want to eyeball this again. I went ahead and just removed the check, as rally will just create the directory if it does not exist, and I ensured its set with a set -u, and then changed it to set +u so the rest of the commands would work (IIRC it was pyenv that failed if set -u is set.
dliappis
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129