Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python 3.8 in Rally tests #815

Merged
merged 4 commits into from
Nov 15, 2019
Merged

Add Python 3.8 in Rally tests #815

merged 4 commits into from
Nov 15, 2019

Conversation

dliappis
Copy link
Contributor

To ensure Rally is compatible with Python 3.8.0.

Closes #809

@dliappis dliappis added the enhancement Improves the status quo label Nov 13, 2019
@danielmitterdorfer danielmitterdorfer added this to the 1.4.0 milestone Nov 13, 2019
@danielmitterdorfer danielmitterdorfer added the :misc Changes that don't affect users directly: linter fixes, test improvements, etc. label Nov 13, 2019
danielmitterdorfer
danielmitterdorfer reviewed Nov 13, 2019
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. Looks mostly fine.

danielmitterdorfer
danielmitterdorfer approved these changes Nov 13, 2019
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@dliappis
Copy link
Contributor Author

This needs to be merged after a new Packer CI images has been created, which depends on the completion of https://github.com/elastic/infra/pull/15970 / https://infra-ci.elastic.co/job/elastic+infra+pull-request+packer-builder-linux/52/

@dliappis dliappis merged commit 841886d into elastic:master Nov 15, 2019
@dliappis dliappis deleted the python38-support branch November 15, 2019 06:47
@hub-cap hub-cap added the highlight A substantial improvement that is worth mentioning separately in release notes label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees
No one assigned
Labels
enhancement Improves the status quo highlight A substantial improvement that is worth mentioning separately in release notes :misc Changes that don't affect users directly: linter fixes, test improvements, etc.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Running Rally with Python 3.8
3 participants
@dliappis @danielmitterdorfer @hub-cap