Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Rally with Python 3.8 #809

Closed
2 tasks done
dliappis opened this issue Nov 11, 2019 · 1 comment · Fixed by #815
Closed
2 tasks done

Running Rally with Python 3.8 #809

dliappis opened this issue Nov 11, 2019 · 1 comment · Fixed by #815
Assignees
Labels
enhancement Improves the status quo

Comments

@dliappis
Copy link
Contributor

dliappis commented Nov 11, 2019

Python 3.8 was released on Oct 14 2019.

This ticket tracks:

  • evaluating compatibility with Python 3.8
  • identifying necessary changes (depending on issues identified) to support 3.8
@dliappis dliappis added the enhancement Improves the status quo label Nov 11, 2019
@dliappis dliappis self-assigned this Nov 11, 2019
@dliappis
Copy link
Contributor Author

dliappis commented Nov 13, 2019

  1. The Python Elasticsearch-Client (version 7.0.5 that we are currently using) is compatible with Python 3.8.

  2. Installing Thespian (version 3.9.3 when using Python 3.8 generates some non-fatal warnings

    Non fatal syntax warnings while installing Thespian 3.9.3 with Python 3.8.0
    warning: no files found matching '*.txt' under directory 'contrib'
        warning: no files found matching '*.txt' under directory 'examples'
        build/bdist.linux-x86_64/egg/thespian/runcommand.py:427: SyntaxWarning: "is" with a literal. Did you mean "=="?
        if outmark is 'normal' else
        build/bdist.linux-x86_64/egg/thespian/runcommand.py:429: SyntaxWarning: "is" with a literal. Did you mean "=="?
        if outmark is 'normal':
        build/bdist.linux-x86_64/egg/thespian/runcommand.py:431: SyntaxWarning: "is" with a literal. Did you mean "=="?
        elif outmark is 'error':
        zip_safe flag not set; analyzing archive contents...
        thespian.__pycache__.director.cpython-38: module references __file__
        thespian.__pycache__.director.cpython-38: module references __path__
        thespian.system.__pycache__.sourceLoader.cpython-38: module references __file__
        thespian.system.__pycache__.sourceLoader.cpython-38: module references __path__
        thespian.system.admin.__pycache__.adminCore.cpython-38: module references __file__
        /var/lib/jenkins/.local/lib/python3.8/site-packages/thespian-3.9.3-py3.8.egg/thespian/runcommand.py:427: SyntaxWarning: "is" with a literal. Did you mean "=="?
        if outmark is 'normal' else
        /var/lib/jenkins/.local/lib/python3.8/site-packages/thespian-3.9.3-py3.8.egg/thespian/runcommand.py:429: SyntaxWarning: "is" with a literal. Did you mean "=="?
        if outmark is 'normal':
        /var/lib/jenkins/.local/lib/python3.8/site-packages/thespian-3.9.3-py3.8.egg/thespian/runcommand.py:431: SyntaxWarning: "is" with a literal. Did you mean "=="?
        elif outmark is 'error':
        zip_safe flag not set; analyzing archive contents...
        zip_safe flag not set; analyzing archive contents...
    
  3. make it38 works without issues.

dliappis added a commit that referenced this issue Nov 15, 2019
and update classifiers to include Python 3.8

Relates #815 
Closes #809
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves the status quo
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant