Fail benchmark if assertion could not run #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
added
enhancement
ywelsch
approved these changes
Sep 27, 2022
DJRickyB
approved these changes
Sep 27, 2022
DJRickyB
reviewed
Sep 27, 2022
esrally/driver/runner.py
Outdated
| @@ -404,7 +404,7 @@ async def __call__(self, *args): | |||
| props = parse(return_value, assertion["property"]) | |||
| self.check_assertion(op_name, assertion, props, props_expand_keys=False) | |||
| else: | |||
| self.logger.debug("Skipping assertion check in [%s] as [%s] does not return a dict.", op_name, repr(self.delegate)) | |||
| raise exceptions.DataError(f"Cannot check assertion in [{op_name}] as [{repr(self.delegate)}] does not return a dict.") | |||
There was a problem hiding this comment.
The only nit I have here is that perhaps this could say did not return a dict, as it could be that the operation typically returns a valid parseable response, but in this instance returned a stacktrace or something
There was a problem hiding this comment.
Thanks, I fixed that. Well it could also return JSON encoded as bytes in a BytesIO but I did not want to overcomplicate the error message.
Like the json module from the standard library, ijson expect bytes. While the signature of `parse()` is type hinted correctly, types are not enforced and many tests were passing a StringIO instance incorrectly. This produced deprecation warnings locally, but not on CI for unknown reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you 1/ enable assertions and 2/ have assertions in your track but 3/ the operation is returning an unsupported type, we used to only issue a debug log! I believe that we should instead complain loudly. This is technically breaking but will only report valid issues so I think it makes sense to include in the next minor version of Rally.
This was initially reported by @ywelsch in #1582 (comment).