Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document valid conditions for making assertions #1582

Open
ywelsch opened this issue Sep 15, 2022 · 1 comment
Open

Document valid conditions for making assertions #1582

ywelsch opened this issue Sep 15, 2022 · 1 comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc. :Docs Changes to the documentation

Comments

@ywelsch
Copy link
Contributor

ywelsch commented Sep 15, 2022

The documentation (see https://esrally.readthedocs.io/en/stable/recipes.html?highlight=debug#checking-queries-and-responses) does not describe what fields are available and what conditions are supported in assertions on responses.

For example, I tried using assertions on a raw-request, which was just silently ignored by the system.

Further, it is unclear what fields are available and what comparison operators you can use.

@ywelsch
Copy link
Contributor Author

ywelsch commented Sep 15, 2022

Additionally, rally currently silently ignores assertions (just logging a DEBUG message), maybe this should be treated as a hard failure (see

self.logger.debug("Skipping assertion check in [%s] as [%s] does not return a dict.", op_name, repr(self.delegate))
)

ywelsch added a commit that referenced this issue Sep 27, 2022
Adds support for assertions on raw requests.

Relates #1582

Co-authored-by: Quentin Pradet <[email protected]>
@ebadyano ebadyano added :Docs Changes to the documentation cleanup Linter changes, reformatting, removal of unused code etc. labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Linter changes, reformatting, removal of unused code etc. :Docs Changes to the documentation
Projects
None yet
Development

No branches or pull requests

2 participants