Require JDK 10 for source builds #450
Assignees
Labels
:Benchmark Candidate Management
Anything affecting how Rally sets up Elasticsearch
enhancement
Improves the status quo
Milestone
Comments
dliappis
added
:Benchmark Candidate Management
dliappis
added a commit
to dliappis/rally
that referenced
this issue
Mar 27, 2018
Similar to the work done for elastic#387, following the merge of the Elasticsearch PR[1], Rally needs to require java-10 to build Elasticsearch from source. Bump the configuration version to 14 and adjust migration of existing configs to support building with java-10. Also add needed test cases. Note that building from source with java-10 requires, at minimum, gradle 4.5[2]. This helps us remove a number of additional gradle options that were needed for java-9. So for now, building will fail with gradle <4.5, which will won't be a worry at all once we start using `./gradlew`; this is tracked in issue#412. Closes elastic#450 [1] elastic/elasticsearch#29174 [2] gradle/gradle#3892
dliappis
added a commit
to dliappis/rally
that referenced
this issue
Mar 27, 2018
Similar to the work done for elastic#387, following the merge of the Elasticsearch PR[1], Rally needs to require java-10 to build Elasticsearch from source. Bump the configuration version to 14 and adjust migration of existing configs to support building with java-10. Also add needed test cases and update docs. Note that building from source with java-10 requires, at minimum, gradle 4.5[2]. This helps us remove a number of additional gradle options that were needed for java-9. So for now, building will fail with gradle <4.5, which will won't be a worry at all once we start using `./gradlew`; this is tracked in issue#412. Closes elastic#450 [1] elastic/elasticsearch#29174 [2] gradle/gradle#3892
dliappis
added a commit
that referenced
this issue
Mar 28, 2018
Similar to the work done for #387, following the merge of the Elasticsearch PR[1], Rally needs to require java-10 to build Elasticsearch from source. Bump the configuration version to 14 and adjust migration of existing configs to support building with java-10. Also add needed test cases and update docs. Note that building from source with java-10 requires, at minimum, gradle 4.5[2]. This helps us remove a number of additional gradle options that were needed for java-9. So for now, building will fail with gradle <4.5, which will won't be a worry at all once we start using `./gradlew`; this is tracked in issue#412. Closes #450 Relates #451 [1] elastic/elasticsearch#29174 [2] gradle/gradle#3892
dliappis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When elastic/elasticsearch#29174 gets merged, source builds of Elasticsearch master will require Java 10, at minimum.
We need to modify the existing code to check for a Java 10 installation / and the user and set it when users want to build Elasticsearch from sources.
Relates #387
Relates #412
The text was updated successfully, but these errors were encountered: