Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require JDK 10 to build Elasticsearch #29174

Merged
merged 3 commits into from
Mar 27, 2018

Conversation

jasontedor
Copy link
Member

This commit bumps the minimum compiler version required to build Elasticsearch from JDK 9 to JDK 10.

This commit bumps the minimum compiler version required to build
Elasticsearch from JDK 9 to JDK 10.
@jasontedor jasontedor requested a review from rjernst March 20, 2018 17:40
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need CI updated first.

* master:
  Fix BWC issue for PreSyncedFlushResponse
  Remove BytesArray and BytesReference usage from XContentFactory (elastic#29151)
  Add pluggable XContentBuilder writers and human readable writers (elastic#29120)
  Add unreleased version 6.2.4 (elastic#29171)
  Add unreleased version 6.1.5 (elastic#29168)
  Add a note about using the `retry_failed` flag before accepting data loss (elastic#29160)
  Fix typo in percolate-query.asciidoc (elastic#29155)
  Require HTTP::Tiny 0.070 for release notes script
@jasontedor
Copy link
Member Author

@rjernst Yes, I opened an issue with them for that this morning.

@hub-cap hub-cap added :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts and removed :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts labels Mar 22, 2018
* master: (40 commits)
  Do not optimize append-only if seen normal op with higher seqno (elastic#28787)
  [test] packaging: gradle tasks for groovy tests (elastic#29046)
  Prune only gc deletes below local checkpoint (elastic#28790)
  remove testUnassignedShardAndEmptyNodesInRoutingTable
  elastic#28745: remove extra option in the composite rest tests
  Fold EngineDiskUtils into Store, for better lock semantics (elastic#29156)
  Add file permissions checks to precommit task
  Remove execute mode bit from source files
  Optimize the composite aggregation for match_all and range queries (elastic#28745)
  [Docs] Add rank_eval size parameter k (elastic#29218)
  [DOCS] Remove ignore_z_value parameter link
  Docs: Update docs/index_.asciidoc (elastic#29172)
  Docs: Link C++ client lib elasticlient (elastic#28949)
  [DOCS] Unregister repository instead of deleting it (elastic#29206)
  Docs: HighLevelRestClient#multiSearch (elastic#29144)
  Add Z value support to geo_shape
  Remove type casts in logging in server component (elastic#28807)
  Change BroadcastResponse from ToXContentFragment to ToXContentObject (elastic#28878)
  REST : Split `RestUpgradeAction` into two actions (elastic#29124)
  Add error file docs to important settings
  ...
dliappis added a commit to dliappis/rally that referenced this pull request Mar 27, 2018
Similar to the work done for elastic#387, following the merge of the
Elasticsearch PR[1], Rally needs to require java-10 to build
Elasticsearch from source.

Bump the configuration version to 14 and adjust migration of existing
configs to support building with java-10. Also add needed test cases.

Note that building from source with java-10 requires, at minimum,
gradle 4.5[2]. This helps us remove a number of additional gradle
options that were needed for java-9. So for now, building will fail
with gradle <4.5, which will won't be a worry at all once we start
using `./gradlew`; this is tracked in issue#412.

Closes elastic#450

[1] elastic/elasticsearch#29174
[2] gradle/gradle#3892
dliappis added a commit to dliappis/rally that referenced this pull request Mar 27, 2018
Similar to the work done for elastic#387, following the merge of the
Elasticsearch PR[1], Rally needs to require java-10 to build
Elasticsearch from source.

Bump the configuration version to 14 and adjust migration of existing
configs to support building with java-10. Also add needed test cases
and update docs.

Note that building from source with java-10 requires, at minimum,
gradle 4.5[2]. This helps us remove a number of additional gradle
options that were needed for java-9. So for now, building will fail
with gradle <4.5, which will won't be a worry at all once we start
using `./gradlew`; this is tracked in issue#412.

Closes elastic#450

[1] elastic/elasticsearch#29174
[2] gradle/gradle#3892
@jasontedor jasontedor merged commit 38fd999 into elastic:master Mar 27, 2018
jasontedor added a commit that referenced this pull request Mar 27, 2018
This commit bumps the minimum compiler version required to build
Elasticsearch from JDK 9 to JDK 10.
@jasontedor jasontedor deleted the bump-compiler-to-jdk-10 branch March 27, 2018 23:55
dliappis added a commit to elastic/rally that referenced this pull request Mar 28, 2018
Similar to the work done for #387, following the merge of the
Elasticsearch PR[1], Rally needs to require java-10 to build
Elasticsearch from source.

Bump the configuration version to 14 and adjust migration of existing
configs to support building with java-10. Also add needed test cases
and update docs.

Note that building from source with java-10 requires, at minimum,
gradle 4.5[2]. This helps us remove a number of additional gradle
options that were needed for java-9. So for now, building will fail
with gradle <4.5, which will won't be a worry at all once we start
using `./gradlew`; this is tracked in issue#412.

Closes #450
Relates #451 

[1] elastic/elasticsearch#29174
[2] gradle/gradle#3892
martijnvg added a commit that referenced this pull request Mar 28, 2018
* es/master: (22 commits)
  Fix building Javadoc JARs on JDK for client JARs (#29274)
  Require JDK 10 to build Elasticsearch (#29174)
  Decouple NamedXContentRegistry from ElasticsearchException (#29253)
  Docs: Update generating test coverage reports (#29255)
  [TEST] Fix issue with HttpInfo passed invalid parameter
  Remove all dependencies from XContentBuilder (#29225)
  Fix sporadic failure in CompositeValuesCollectorQueueTests
  Propagate ignore_unmapped to inner_hits (#29261)
  TEST: Increase timeout for testPrimaryReplicaResyncFailed
  REST client: hosts marked dead for the first time should not be immediately retried (#29230)
  TEST: Use different translog dir for a new engine
  Make SearchStats implement Writeable (#29258)
  [Docs] Spelling and grammar changes to reindex.asciidoc (#29232)
  Do not optimize append-only if seen normal op with higher seqno (#28787)
  [test] packaging: gradle tasks for groovy tests (#29046)
  Prune only gc deletes below local checkpoint (#28790)
  remove testUnassignedShardAndEmptyNodesInRoutingTable
  #28745: remove extra option in the composite rest tests
  Fold EngineDiskUtils into Store, for better lock semantics (#29156)
  Add file permissions checks to precommit task
  ...
martijnvg added a commit that referenced this pull request Mar 28, 2018
* es/6.x:
  Fix building Javadoc JARs on JDK for client JARs (#29274)
  Require JDK 10 to build Elasticsearch (#29174)
  Decouple NamedXContentRegistry from ElasticsearchException (#29253)
  Docs: Update generating test coverage reports (#29255)
  [TEST] Fix issue with HttpInfo passed invalid parameter
  Remove all dependencies from XContentBuilder (#29225)
  Fix sporadic failure in CompositeValuesCollectorQueueTests
  Propagate ignore_unmapped to inner_hits (#29261)
  TEST: Increase timeout for testPrimaryReplicaResyncFailed
  REST client: hosts marked dead for the first time should not be immediately retried (#29230)
  Make SearchStats implement Writeable (#29258)
  [Docs] Spelling and grammar changes to reindex.asciidoc (#29232)
  [test] packaging: gradle tasks for groovy tests (#29046)
  remove testUnassignedShardAndEmptyNodesInRoutingTable
  Add file permissions checks to precommit task
  Remove execute mode bit from source files
  #28745: remove 7.x option in the composite rest tests.
  Optimize the composite aggregation for match_all and range queries (#28745)
  Clarify deprecation warning for auto_generate_phrase_query (#29204)
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v6.3.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants