Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #13715 to 8.1: artifacts: omit openssl_pkcs8_pure specs from built artifacts #13851

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

yaauie
Copy link
Member

@yaauie yaauie commented Mar 4, 2022

Backport PR #13715 to 8.1 branch. Original message:

Release notes

[rn:skip]

What does this PR do?

The openssl_pkcs8_pure gem dependency is a library for transforming key formats, and includes spec artifacts for validating its ability to transform key formats that are not useful at runtime. The presence of theses keys causes false alarms, so this PR ensures they are excluded from our built artifacts.

Why is it important/What is the impact to the user?

Allows our artifacts, or docker containers that import our artifacts, to not trigger false positives against some security policies.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

…c#13715)

* artifacts: omit openssl_pkcs8_pure specs from built artifacts

* Exclude _all_ top-level spec and test directories from built artifacts

Co-authored-by: João Duarte <[email protected]>

Co-authored-by: João Duarte <[email protected]>
(cherry picked from commit 0369ba2)
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@yaauie yaauie merged commit 5534ca3 into elastic:8.1 Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants