artifacts: omit openssl_pkcs8_pure specs from built artifacts #13715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
reviewed
Feb 3, 2022
Co-authored-by: João Duarte <[email protected]>
|
Test failure unrelated, and logged in an existing tracking issue: #7724 (comment) jenkins test this please |
|
New failure, also tracked in #13666 |
…pure-specs-from-built-artifacts
yaauie
added a commit
to yaauie/logstash
that referenced
this pull request
Mar 4, 2022
…c#13715) * artifacts: omit openssl_pkcs8_pure specs from built artifacts * Exclude _all_ top-level spec and test directories from built artifacts Co-authored-by: João Duarte <[email protected]> Co-authored-by: João Duarte <[email protected]> (cherry picked from commit 0369ba2)
Merged
2 tasks
yaauie
added a commit
to yaauie/logstash
that referenced
this pull request
Mar 4, 2022
…c#13715) * artifacts: omit openssl_pkcs8_pure specs from built artifacts * Exclude _all_ top-level spec and test directories from built artifacts Co-authored-by: João Duarte <[email protected]> Co-authored-by: João Duarte <[email protected]> (cherry picked from commit 0369ba2)
Merged
2 tasks
yaauie
added a commit
that referenced
this pull request
Mar 5, 2022
…from built artifacts (#13852) * artifacts: omit openssl_pkcs8_pure specs from built artifacts (#13715) * artifacts: omit openssl_pkcs8_pure specs from built artifacts * Exclude _all_ top-level spec and test directories from built artifacts Co-authored-by: João Duarte <[email protected]> Co-authored-by: João Duarte <[email protected]> (cherry picked from commit 0369ba2) * Update releasenotes.asciidoc (#13701) Fixed OS name. Ubuntu instead of Ununtu. Co-authored-by: Cris da Rocha <[email protected]>
yaauie
added a commit
that referenced
this pull request
Mar 5, 2022
#13851) * artifacts: omit openssl_pkcs8_pure specs from built artifacts * Exclude _all_ top-level spec and test directories from built artifacts Co-authored-by: João Duarte <[email protected]> Co-authored-by: João Duarte <[email protected]> (cherry picked from commit 0369ba2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
The
openssl_pkcs8_puregem dependency is a library for transforming key formats, and includes spec artifacts for validating its ability to transform key formats that are not useful at runtime. The presence of theses keys causes false alarms, so this PR ensures they are excluded from our built artifacts.Why is it important/What is the impact to the user?
Allows our artifacts, or docker containers that import our artifacts, to not trigger false positives against some security policies.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature works