-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix index pattern create with cross cluster search _and_ partial results #94664
Conversation
Pinging @elastic/kibana-app-services (Team:AppServices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments
...ns/index_pattern_management/public/components/create_index_pattern_wizard/lib/get_indices.ts
Outdated
Show resolved
Hide resolved
...dex_pattern_management/public/components/create_index_pattern_wizard/lib/get_indices.test.ts
Show resolved
Hide resolved
@@ -93,6 +102,22 @@ describe('getIndices', () => { | |||
).toBe(0); | |||
}); | |||
|
|||
it('should work with partial responses', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add a test for an error response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a test for handing errors at the end of this document, do you think its sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm talking about an error response , not an exception being thrown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lizozom Addressed based on util code for checking for errors. I'm not sure if there are other error formats I should be testing.
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/ml·ts.ml for user with full ML access with data loaded data frame analytics create job create step for outlier jobStandard Out
Stack Trace
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…lts (elastic#94664) * fix index pattern create with cross cluster and partial results and update tests
…lts (elastic#94664) * fix index pattern create with cross cluster and partial results and update tests
…lts (#94664) (#94818) * fix index pattern create with cross cluster and partial results and update tests Co-authored-by: Kibana Machine <[email protected]>
Index pattern create flow will show errors when using cross cluster search AND partial search results are returned from the index list query. This fixes the problem and adds a test to verify the fix.