improve tests

elastic · Mar 16, 2021 · bd96814 · bd96814
1 parent 6fcbcc7
commit bd96814
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/src/plugins/data/common/search/utils.ts b/src/plugins/data/common/search/utils.ts
@@ -12,7 +12,7 @@ import type { IKibanaSearchResponse } from './types';
  * @returns true if response had an error while executing in ES
  */
 export const isErrorResponse = (response?: IKibanaSearchResponse) => {
-  return !response || (!response.isRunning && response.isPartial);
+  return !response || (!response.isRunning && !!response.isPartial);
 };
 
 /**

diff --git a/..._pattern_management/public/components/create_index_pattern_wizard/lib/get_indices.test.ts b/..._pattern_management/public/components/create_index_pattern_wizard/lib/get_indices.test.ts
@@ -34,6 +34,8 @@ export const successfulResolveResponse = {
 };
 
 const successfulSearchResponse = {
+  isPartial: false,
+  isRunning: false,
   rawResponse: {
     aggregations: {
       indices: {
@@ -44,6 +46,8 @@ const successfulSearchResponse = {
 };
 
 const partialSearchResponse = {
+  isPartial: true,
+  isRunning: true,
   rawResponse: {
     hits: {
       total: 2,

diff --git a/...index_pattern_management/public/components/create_index_pattern_wizard/lib/get_indices.ts b/...index_pattern_management/public/components/create_index_pattern_wizard/lib/get_indices.ts
@@ -91,8 +91,10 @@ export const getIndicesViaSearch = async ({
       },
     },
   })
-    .pipe(filter((resp) => isCompleteResponse(resp) || !!isErrorResponse(resp)))
-    .pipe(map(searchResponseToArray(getIndexTags, showAllIndices)))
+    .pipe(
+      filter((resp) => isCompleteResponse(resp) || isErrorResponse(resp)),
+      map(searchResponseToArray(getIndexTags, showAllIndices))
+    )
     .toPromise()
     .catch(() => []);