[maps] abort sync data if any data request fails #87381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
@elasticmachine merge upstream |
thomasneirynck
approved these changes
Jan 11, 2021
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 11, 2021
* [maps] abort sync data if any data request fails * review feedback * fix broken rename of e to error Co-authored-by: Kibana Machine <[email protected]>
nreese
added a commit
that referenced
this pull request
Jan 11, 2021
* [maps] abort sync data if any data request fails * review feedback * fix broken rename of e to error Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #87310, I discovered that an aborted data request in vectorLayer.syncData does not stop the syncData thread.
Below is the case for making these changes
_syncDatacalls_syncSourceStyleMetawhich starts a data request to fetch the style meta_syncSourceStyleMetareturns, user changes time range._syncDatacall which calls_syncSourceStyleMeta. The original_syncSourceStyleMetais aborted but its run context is not. The original thread then attempts to call the rest of_syncDatastatements like_syncSource.What should happen is that the syncData thread ends on a data load error instead of continuing execution.