[Maps] fix multi-select query from Controls visualization not always getting applied to map in dashboard #87310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getting applied to map in dashboard
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
@elasticmachine merge upstream |
thomasneirynck
approved these changes
Jan 7, 2021
| dispatch: ThunkDispatch<MapStoreState, void, AnyAction>, | ||
| getState: () => MapStoreState | ||
| ) => { | ||
| dispatch(unregisterCancelCallback(requestToken)); | ||
| const dataRequest = getDataRequestDescriptor(getState(), layerId, dataId); |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 7, 2021
…getting applied to map in dashboard (elastic#87310) * [Maps] fix multi-select query from Controls visualization not always getting applied to map in dashboard * fix underlying problem in blended layer * clean-up Co-authored-by: Kibana Machine <[email protected]>
This was referenced Jan 7, 2021
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jan 7, 2021
…getting applied to map in dashboard (elastic#87310) * [Maps] fix multi-select query from Controls visualization not always getting applied to map in dashboard * fix underlying problem in blended layer * clean-up Co-authored-by: Kibana Machine <[email protected]>
nreese
added a commit
that referenced
this pull request
Jan 7, 2021
…getting applied to map in dashboard (#87310) (#87687) * [Maps] fix multi-select query from Controls visualization not always getting applied to map in dashboard * fix underlying problem in blended layer * clean-up Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
nreese
added a commit
that referenced
this pull request
Jan 7, 2021
…getting applied to map in dashboard (#87310) (#87688) * [Maps] fix multi-select query from Controls visualization not always getting applied to map in dashboard * fix underlying problem in blended layer * clean-up Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87301
Controls visualization makes 2 changes to filterManager. The first change removes the existing filter for the control, while the second change creates the new filter. This resulted in MapEmbeddable.onContainerStateChanged getting called twice, once with empty filters and once with the actual filter. This resulted in the search without the filter.
Lens and visualize embeddables where not effected by this and where not getting called with the empty filter state. Looking into those embeddables, they subscribe to
getUpdated$instead ofgetInput$to listen for changes. getUpdate is just a debounce wrapper around getInput. This PR resolves the issue by subscribing to changes withgetUpdated$like lens and visualize embeddable.Having 2 filter changes exposed a bug in blended vector layer. The original request to fetch the number of documents in view should be aborted when the second request starts. When aborted, the original request should exit sync data. Blended layer has a bug where "count" requests do not register a callback. Thus, when the second request starts, the first request is not aborted and continues to sync data. This PR also addressed this problem and registers an abort signal for the "count" request.
Finally,
endDataLoadwas updated to throw a DataRequestAbortError when processing the response to an outdated request. While blended layer had a bug, there should be good logic in redux store actions to ensure the response is for the active request. This check would have prevented the entire problem.