Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Documents view: misc responsive tweaks #85440

Merged
merged 2 commits into from
Dec 15, 2020
Merged

[App Search] Documents view: misc responsive tweaks #85440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5deb98
Misc responsive tweaks to Documents view
cee-chen Dec 9, 2020
7758c83
Merge branch 'master' into documents-responsive
kibanamachine Dec 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...arch/public/applications/app_search/components/documents/search_experience/pagination.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ import { Paging, ResultsPerPage } from '@elastic/react-search-ui';
import { PagingView, ResultsPerPageView } from './views';

export const Pagination: React.FC<{ 'aria-label': string }> = ({ 'aria-label': ariaLabel }) => (
<EuiFlexGroup alignItems="center" className="documentsSearchExperience__pagingInfo">
<EuiFlexGroup
alignItems="center"
responsive={false}
className="documentsSearchExperience__pagingInfo"
>
<EuiFlexItem>
<Paging view={PagingView} aria-label={ariaLabel} />
</EuiFlexItem>
Expand Down
2 changes: 1 addition & 1 deletion .../applications/app_search/components/documents/search_experience/views/search_box_view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const SearchBoxView: React.FC<Props> = ({ onChange, value, inputProps })
<EuiFieldSearch
value={value}
onChange={(event) => onChange(event.target.value)}
fullWidth={true}
fullWidth
{...inputProps}
/>
);
Expand Down
5 changes: 3 additions & 2 deletions ...lic/applications/app_search/components/documents/search_experience/views/sorting_view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ export const SortingView: React.FC<Props> = ({ onChange, options, value }) => {
const selectedValue = value && !valuesFromOptions.includes(value) ? undefined : value;

return (
<div>
<>
<EuiSelect
fullWidth
options={options.map(wrapSortingOptionForEuiSelect)}
value={selectedValue}
prepend={i18n.translate('xpack.enterpriseSearch.appSearch.documents.search.sortBy', {
Expand All @@ -48,6 +49,6 @@ export const SortingView: React.FC<Props> = ({ onChange, options, value }) => {
}
)}
/>
</div>
</>
);
};