Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Documents view: misc responsive tweaks #85440

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

cee-chen
Copy link
Contributor

@cee-chen cee-chen commented Dec 9, 2020

Summary

I noticed while responsive/mobile QAing #85046 that the Documents view Search UI could benefit from some super tiny tweaks for a better mobile experience.

Before

Screen Shot 2020-12-09 at 9 15 04 AM

After

Screen Shot 2020-12-09 at 9 15 22 AM

There's maybe still some extra CSS we could potentially add around spacing and so forth, but I'll wait until after the filters sidebar gets added to evaluate.

Checklist

  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

+ misc cleanup - extra div, true
@cee-chen cee-chen added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 9, 2020
@cee-chen cee-chen requested review from JasonStoltz and a team December 9, 2020 17:19
@cee-chen
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB +74.0B

Distributable file count

id before after diff
default 47130 47890 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 07f395f into elastic:master Dec 15, 2020
@cee-chen cee-chen deleted the documents-responsive branch December 15, 2020 17:02
cee-chen pushed a commit that referenced this pull request Dec 15, 2020
+ misc cleanup - extra div, true

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants