-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create index pattern - support older CCS clusters #80006
Merged
mattkime
merged 1 commit into
elastic:7.x
from
mattkime:create_index_pattern_cross_cluster_support_7x
Oct 8, 2020
Merged
Create index pattern - support older CCS clusters #80006
mattkime
merged 1 commit into
elastic:7.x
from
mattkime:create_index_pattern_cross_cluster_support_7x
Oct 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-app-arch (Team:AppArch) |
1 task
lukeelmers
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, seems in line with the previous PR
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Oct 8, 2020
…tiblity (elastic#80006) # Conflicts: # src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.tsx # src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/create_index_pattern_wizard.tsx # src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/lib/get_indices.test.ts # src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/lib/get_indices.ts # src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx
mattkime
added a commit
that referenced
this pull request
Oct 11, 2020
This was referenced Oct 11, 2020
mattkime
added a commit
to mattkime/kibana
that referenced
this pull request
Oct 11, 2020
mattkime
added a commit
that referenced
this pull request
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Data Views
Data Views code and UI - index patterns before 8.0
release_note:fix
v7.9.3
v7.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #77825
Cross cluster search supports all matching major versions and the previous major version.latest. The
resolve
endpoint was only added in v7.9 so we can't rely on it in cross cluster index pattern creation for 7.x releases. This PR restores the prior implementation of using an aggregation query when creating a cross cluster index pattern. A cross cluster pattern*:*
will use both new and old methods and merge the results whereas a local pattern (no colon) will only use the resolve endpoint.Testing
Test against a local elasticsearch instance as well as against a v6.latest remote cluster.
Checklist
Release notes
Fixes index pattern creation when using cross cluster search with clusters running <7.9.