Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create index pattern - support older CCS clusters #80006

Merged

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 8, 2020

Summary

Addresses #77825

Cross cluster search supports all matching major versions and the previous major version.latest. The resolve endpoint was only added in v7.9 so we can't rely on it in cross cluster index pattern creation for 7.x releases. This PR restores the prior implementation of using an aggregation query when creating a cross cluster index pattern. A cross cluster pattern *:* will use both new and old methods and merge the results whereas a local pattern (no colon) will only use the resolve endpoint.

Testing

Test against a local elasticsearch instance as well as against a v6.latest remote cluster.

Checklist

Release notes

Fixes index pattern creation when using cross cluster search with clusters running <7.9.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v7.10 v7.10.0 v7.9.3 labels Oct 8, 2020
@mattkime mattkime added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Oct 8, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
indexPatternManagement 662.9KB 667.9KB +5.0KB

page load bundle size

id before after diff
indexPatternManagement 136.1KB 136.2KB +73.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, seems in line with the previous PR

@mattkime mattkime merged commit 27f461a into elastic:7.x Oct 8, 2020
mattkime added a commit to mattkime/kibana that referenced this pull request Oct 8, 2020
…tiblity (elastic#80006)

# Conflicts:
#	src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/components/step_index_pattern/step_index_pattern.tsx
#	src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/create_index_pattern_wizard.tsx
#	src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/lib/get_indices.test.ts
#	src/plugins/index_pattern_management/public/components/create_index_pattern_wizard/lib/get_indices.ts
#	src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx
@jen-huang jen-huang removed the v7.10 label Oct 8, 2020
mattkime added a commit to mattkime/kibana that referenced this pull request Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:fix v7.9.3 v7.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants