XPack-Accessibility- Grok Debugger Test #62104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmivkulkarni
added
Project:Accessibility
Feature:Grok Debugger
|
@Rasroh each of the steps here need to pass through a11y validation: And they need to be in separate tests as well for clarity. Thanks! |
… test as there is a aria violation
rashmivkulkarni
changed the title
rashmivkulkarni
requested review from
aunikb,
bhavyarm and
myasonik
and removed request for
aunikb
bhavyarm
reviewed
Apr 2, 2020
rashmivkulkarni
changed the title
myasonik
approved these changes
Apr 2, 2020
...the actions they are performing
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
LGTM! |
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Apr 3, 2020
* accessibility tests for dashboard panel * added back the skipped test as it is still required to pass through th ea11ySnapshot * accessibility grok debugger test - currently skipped due to aria label violation * deleting a file which was added accidentally * deleting a file which was added accidentally * incorporated feedback split tests into seperate tests and skipped the test as there is a aria violation * commented out the grok debugger config file entry * re-added the test in config file * updated the tests to match ...the actions they are performing * fixed syntax Co-authored-by: Elastic Machine <[email protected]>
rashmivkulkarni
added a commit
that referenced
this pull request
Apr 3, 2020
* accessibility tests for dashboard panel * added back the skipped test as it is still required to pass through th ea11ySnapshot * accessibility grok debugger test - currently skipped due to aria label violation * deleting a file which was added accidentally * deleting a file which was added accidentally * incorporated feedback split tests into seperate tests and skipped the test as there is a aria violation * commented out the grok debugger config file entry * re-added the test in config file * updated the tests to match ...the actions they are performing * fixed syntax Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta issue: #51456
Sub issue: #62103
Currently this test is being skipped as there is a
aria-labelviolation on grok debugger page which needs to be fixed.associated bug: #62102 ( aria-label violation)