Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - Grok Debugger aria label violation #62102

Closed
rashmivkulkarni opened this issue Apr 1, 2020 · 1 comment · Fixed by #131564
Closed

Accessibility - Grok Debugger aria label violation #62102

rashmivkulkarni opened this issue Apr 1, 2020 · 1 comment · Fixed by #131564
Labels
bug Fixes for quality problems that affect the customer experience Feature:Grok Debugger Dev Tools Grok Debugger feature Feature:xpack_main loe:small Small Level of Effort Project:Accessibility skipped-test Team:Observability Team label for Observability Team (for things that are handled across all of observability)

Comments

@rashmivkulkarni
Copy link
Contributor

Kibana version: 8.0

Elasticsearch version: 8.0

Xpack > grok Debugger> When I run the axe plugin on grok Debugger page, I found 3 aria-label violations as shown in the screenshot below. Trying to write an automated test for this to run it via a11y tool and here is the console output .

 Dev tools grok debugger
       Dev tools grok debugger view:
     Error: a11y report:

VIOLATION
  [label]: Ensures every form element has a label
    Help: https://dequeuniversity.com/rules/axe/3.5/label?application=axeAPI
    Elements:
      - #i47c56f00-73ce-11ea-8157-57c818c89eff_4a79b990-73ce-11ea-8157-57c818c89eff > textarea
      - #i47c5bd20-73ce-11ea-8157-57c818c89eff_4a7a07b0-73ce-11ea-8157-57c818c89eff > textarea
      - #i47c743c0-73ce-11ea-8157-57c818c89eff_4a7a2ec1-73ce-11ea-8157-57c818c89eff > textarea
      at Accessibility.testAxeReport (/Users/rashmikulkarni/my_workspace/kibana/test/accessibility/services/a11y/a11y.ts:85:15)
      at Accessibility.testAppSnapshot (/Users/rashmikulkarni/my_workspace/kibana/test/accessibility/services/a11y/a11y.ts:58:18)
      at process._tickCallback (internal/process/next_tick.js:68:7)

Screen Shot 2020-03-31 at 9 12 03 PM

cc @bhavyarm @myasonik

@rashmivkulkarni rashmivkulkarni added bug Fixes for quality problems that affect the customer experience Project:Accessibility Feature:xpack_main Feature:Grok Debugger Dev Tools Grok Debugger feature labels Apr 1, 2020
@myasonik
Copy link
Contributor

myasonik commented Apr 1, 2020

Fixed a similar problem elsewhere in Kibana: https://github.com/elastic/kibana/blob/master/src/plugins/console/public/application/components/editor_example.tsx#L34-L45

The solution should be reusable here. Feel free to ping me if anything is unclear.

@myasonik myasonik added the Team:Observability Team label for Observability Team (for things that are handled across all of observability) label Apr 1, 2020
@myasonik myasonik added the loe:small Small Level of Effort label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Grok Debugger Dev Tools Grok Debugger feature Feature:xpack_main loe:small Small Level of Effort Project:Accessibility skipped-test Team:Observability Team label for Observability Team (for things that are handled across all of observability)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants