Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removes CTA from Task Manager info message #55334

Merged
merged 8 commits into from
Jan 20, 2020
Merged

removes CTA from Task Manager info message #55334

merged 8 commits into from
Jan 20, 2020

Conversation

gmmorris
Copy link
Contributor

@gmmorris gmmorris commented Jan 20, 2020 •
edited
Loading

Summary

Remove the call to action from a TaskManager info message as we don't want to encourage this behaviour.

Done in reference to #54920 (comment)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@gmmorris
fixed snapshots broken by merge
f9e63f7
@gmmorris
Merge remote-tracking branch 'upstream/master'
af07e54 
* upstream/master: (26 commits)
  Take page offset into account too (elastic#54567)
  [APM] Support error.{log,exception}.stacktrace.classname (elastic#54577)
  Np migration tsvb route validation (elastic#51850)
  [ML] MML calculator enhancements for multi-metric job wizard  (elastic#54573)
  [SIEM] Fix Inspect query 'request timestamp' value changes when curso… (elastic#54223)
  Fix chromeless NP apps not using full page width (elastic#54550)
  Remove extraneous public import to prevent failing Kibana startup (elastic#54676)
  [Uptime] Temporarily skip flakey tests (elastic#54675)
  Skip failing uptime tests
  Create UI for alerting and actions plugin (elastic#48959)
  [dev/build/sass] build stylesheets for disabled plugins too (elastic#54654)
  [SIEM] Use bulk actions API when updating or deleting rules (elastic#54521)
  Support "Deprecated" label in advanced settings (elastic#54539)
  [Maps] add text halo color and width style properties (elastic#53827)
  Service Map Data API at Runtime (elastic#54027)
  [SIEM] Detection Engine Create Rule Design Review #1 (elastic#54442)
  Skip flaky test
  [Canvas] Enable Embeddable maps (elastic#53971)
  [SIEM][Detection Engine] Increases the number or rules you can view on a single page (elastic#54628)
  uiSettings - use validation field for image field maxSize (elastic#54522)
  ...
@gmmorris
Merge remote-tracking branch 'upstream/master'
bfdb1ea 
* upstream/master: (72 commits)
  [ML] Calculate model memory limit API integration tests (elastic#54557)
  Skip flakey index template component integration tests. (elastic#54878)
  Add label and icon to nested fields in the doc table (elastic#54199)
  Reverse dependency of home plugin and apm/ml/cloud (elastic#52883)
  [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules
  update invalid snapshot
  add readme note about alerting / manage_api_key cluster privilege (elastic#54639)
  [SIEM] New Overview Page (elastic#54783)
  [Uptime] Feature/refactor context initialization (elastic#54494)
  Upgrade EUI to v18.2.0 (elastic#54786)
  [SIEM] [Detection engine] from signals to timeline (elastic#54769)
  [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562)
  [SIEM][Detection Engine] Removes deprecated filter from mapping
  [Maps] Add categorical styling (elastic#54408)
  Add mapbox-gl-rtl-text library (elastic#54842)
  [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828)
  Lexicographically sort location tags (elastic#54832)
  [Maps] expand extent filter to tile boundaries (elastic#54276)
  [Maps] Use v7.6 Elastic Maps Service API (elastic#54399)
  [DOCS] Adds monitoring setting (elastic#54819)
  ...
@gmmorris
Merge remote-tracking branch 'upstream/master'
edb0145 
* upstream/master: (83 commits)
  [Reporting] Fix map tiles not loading by using Chrome's Remote Protocol (elastic#55137)
  [Data Plugin] combine autocomplete provider and suggestions provider (elastic#54451)
  resolves elastic#53038 - remove references to specific license levels (elastic#53858)
  highlighting rules should still know about url parts when in sql state (elastic#55200)
  [Metric] convert mocha tests to jest (elastic#54054)
  [skip-ci] Update vector styling docs for 7.6 UI changes and new features (elastic#55087)
  Fix enable API to schedule task after alert is updated (elastic#55095)
  chore(NA): add 7.6 branch to the list of backport branches (elastic#54998)
  Convert tests to jest in vis_type_timeseries/public & common folders (elastic#55023)
  [ML] Accessibility fix for structural markup on table rows (elastic#55075)
  [Mappings editor] include/exclude fields only support custom options (elastic#54949)
  [Vis] Move Timelion Vis to vis_type_timelion (elastic#52069)
  Deprecate `chrome.navlinks.update` and add documentation (elastic#54893)
  [ML] Single Metric Viewer: Fix time bounds with custom strings. (elastic#55045)
  [Vis: Default editor] EUIficate and Reactify the sidebar (elastic#49864)
  [Mappings editor] Fix cannot set boolean value for "null_value" param (elastic#55015)
  [SIEM] Adds support for apm-* to the network map (elastic#54876)
  [Reporting] Define shims of legacy dependencies (elastic#54082)
  Resolver is overflow: hidden to prevent obscured elements from showing up (elastic#55076)
  Upgraded EUI to 18.2.1 (elastic#55090)
  ...
@gmmorris
Merge remote-tracking branch 'upstream/master'
946183c 
* upstream/master: (24 commits)
  Show error page when accessing unavailable app (elastic#54656)
  [ML] Improving job wizards with datafeed aggregations (elastic#55180)
  remove flaly assetion. a license presence tested anyway (elastic#55289)
  fix commonly used ranges uptime (elastic#54930)
  [SIEM] Use proper icons on Detections view (elastic#55215)
  Fix: invalid translation referenced (elastic#54901)
  [State Management] Remove AppState from edit_index_pattern page (elastic#54104)
  Implements `getStartServices` on server-side (elastic#55156)
  Move vis_vega_type/data_model tests to jest (elastic#55186)
  [SIEM] [Detection Engine] Update status on rule details page (elastic#55201)
  Fix KQL value suggestions for nested fields (elastic#54820)
  Enforce camelCase format for a plugin id (elastic#53759)
  [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069)
  Remove nested root from index pattern (elastic#54978)
  [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198)
  [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252)
  [SIEM] Detections add alert & signal tab (elastic#55127)
  Management API - redirect on disabled app path (elastic#55136)
  [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags
  update local (elastic#55177)
  ...
@gmmorris
Merge remote-tracking branch 'upstream/master'
e50378d 
* upstream/master:
  [ML] Single Metric Viewer: Fix job check. (elastic#55191)
@gmmorris
Merge remote-tracking branch 'upstream/master'
4b6aedf 
* upstream/master:
  [ML] Correctly pass on severity value to anomaly explorer charts. (elastic#55207)
@gmmorris
remove CTA from TM info m,essage
c80ec25
@gmmorris gmmorris added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.6.0 v7.7.0 v8.0.0 labels Jan 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris gmmorris added release_note:skip Skip the PR/issue when compiling release notes and removed v7.7.0 labels Jan 20, 2020
@gmmorris gmmorris mentioned this pull request Jan 20, 2020
Closed
mikecote
mikecote approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikecote mikecote added v7.7.0 and removed v7.7.0 labels Jan 20, 2020
@peterschretlen
Copy link
Contributor

@FrankHassanabad FYI we're going to remove the part of that log message that talks about adjusting max_workers for 7.6

pmuellr
pmuellr approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I wonder about logging anything in this case, as it isn't necessarily an indication of a problem. But will be a nice diagnostic until we have better ones :-). We can tweak more in a 7.6.1 if we get a bunch of customer questions about it.

@FrankHassanabad
Copy link
Contributor

Sounds good @peterschretlen, thanks for the ping.

@gmmorris gmmorris merged commit 638792a into elastic:master Jan 20, 2020
@gmmorris gmmorris mentioned this pull request Jan 20, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 20, 2020
@gmmorris
removes CTA from Task Manager info message (elastic#55334)
a275bd2 
removes CTA from Task Manager info message
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 20, 2020
@gmmorris
removes CTA from Task Manager info message (elastic#55334)
e375ec8 
removes CTA from Task Manager info message
@gmmorris gmmorris mentioned this pull request Jan 20, 2020
Merged
@gmmorris gmmorris deleted the task-manager/cta branch January 20, 2020 17:25
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added a commit that referenced this pull request Jan 20, 2020
@gmmorris
removes CTA from Task Manager info message (#55334) (#55343)
1f1a0da 
removes CTA from Task Manager info message
gmmorris added a commit that referenced this pull request Jan 20, 2020
@gmmorris
removes CTA from Task Manager info message (#55334) (#55344)
052fbae 
removes CTA from Task Manager info message
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 21, 2020
@gmmorris
Merge branch 'master' into actions/platform
78e0253 
* master:
  [State Management] remove AppState from Dashboard app (elastic#54105)
  Expose fatalErrors API from the Start contract (elastic#55300)
  [BUG] Data fetching twice on discover timefilter change  (elastic#55279)
  [Mappings editor] Add missing max_shingle_size parameter to search_as_you_type (elastic#55161)
  [Logs UI] Fix z-index of logs page toolbar (elastic#54469)
  removes CTA from Task Manager info message (elastic#55334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuellr pmuellr pmuellr approved these changes

@mikecote mikecote mikecote approved these changes

Assignees
No one assigned
Labels
backported Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gmmorris @elasticmachine @peterschretlen @FrankHassanabad @kibanamachine @pmuellr @mikecote