[State Management] Remove AppState from edit_index_pattern page #54104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Dosant
force-pushed
the
dev/state-managment/state-sync-edit-index-pattern
branch
from
706ccf0 to
43957c8
Compare
Dosant
force-pushed
the
dev/state-managment/state-sync-edit-index-pattern
branch
from
43957c8 to
37e01a0
Compare
Dosant
changed the title
Dosant
added
review
release_note:skip
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@elasticmachine merge upstream |
30 tasks
…agment/state-sync-edit-index-pattern
Dosant
force-pushed
the
dev/state-managment/state-sync-edit-index-pattern
branch
from
8961302 to
3ddbe58
Compare
lizozom
reviewed
Jan 16, 2020
...ns/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.js
Outdated
Show resolved
Hide resolved
...ns/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.js
Outdated
Show resolved
Hide resolved
...ns/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.js
Outdated
Show resolved
Hide resolved
...ns/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.js
Show resolved
Hide resolved
streamich
approved these changes
Jan 16, 2020
...ns/kibana/public/management/sections/index_patterns/edit_index_pattern/edit_index_pattern.js
Outdated
Show resolved
Hide resolved
…agment/state-sync-edit-index-pattern
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Jan 20, 2020
…tic#54104) Replaces AppState in edit_index_pattern with state containers and state syncing utils. In addition makes tab navigation on edit_index_pattern work with browser's undo history Co-authored-by: Elastic Machine <[email protected]>
Dosant
added a commit
that referenced
this pull request
Jan 20, 2020
…) (#55294) Replaces AppState in edit_index_pattern with state containers and state syncing utils. In addition makes tab navigation on edit_index_pattern work with browser's undo history
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* upstream/master: (24 commits) Show error page when accessing unavailable app (elastic#54656) [ML] Improving job wizards with datafeed aggregations (elastic#55180) remove flaly assetion. a license presence tested anyway (elastic#55289) fix commonly used ranges uptime (elastic#54930) [SIEM] Use proper icons on Detections view (elastic#55215) Fix: invalid translation referenced (elastic#54901) [State Management] Remove AppState from edit_index_pattern page (elastic#54104) Implements `getStartServices` on server-side (elastic#55156) Move vis_vega_type/data_model tests to jest (elastic#55186) [SIEM] [Detection Engine] Update status on rule details page (elastic#55201) Fix KQL value suggestions for nested fields (elastic#54820) Enforce camelCase format for a plugin id (elastic#53759) [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069) Remove nested root from index pattern (elastic#54978) [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198) [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252) [SIEM] Detections add alert & signal tab (elastic#55127) Management API - redirect on disabled app path (elastic#55136) [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags update local (elastic#55177) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 20, 2020
* master: (108 commits) [ML] Single Metric Viewer: Fix job check. (elastic#55191) Show error page when accessing unavailable app (elastic#54656) [ML] Improving job wizards with datafeed aggregations (elastic#55180) remove flaly assetion. a license presence tested anyway (elastic#55289) fix commonly used ranges uptime (elastic#54930) [SIEM] Use proper icons on Detections view (elastic#55215) Fix: invalid translation referenced (elastic#54901) [State Management] Remove AppState from edit_index_pattern page (elastic#54104) Implements `getStartServices` on server-side (elastic#55156) Move vis_vega_type/data_model tests to jest (elastic#55186) [SIEM] [Detection Engine] Update status on rule details page (elastic#55201) Fix KQL value suggestions for nested fields (elastic#54820) Enforce camelCase format for a plugin id (elastic#53759) [SIEM] Detection engine cleanup for rule details/creation/edit page (elastic#55069) Remove nested root from index pattern (elastic#54978) [Reporting/Migration] ReportingSetup, LegacySetup (elastic#54198) [SIEM] [Detection Engine] Fixes duplicate rule action (elastic#55252) [SIEM] Detections add alert & signal tab (elastic#55127) Management API - redirect on disabled app path (elastic#55136) [SIEM][Detection Engine] Fixes critical regression on the backend with immutable and tags ...
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #53582Part of #44151
Replaces AppState in
edit_index_patternwith state containers and state syncing utils.In addition makes tab navigation on
edit_index_patternwork with browser's undo historyDisclaimer
The
edit_index_patternpage was used in our StateManagement POC as the simplest place whereAppStatewas used.Not sure if we actually need to apply this change or if this should wait for complete de-angularaization of
edit_index_pattern.but if we merge it - this could be an example of how to use new state containers and state syncing utils in legacy angular code.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers