Re-enable infra visual tests

src/dev/ci_setup/load_env_keys.sh

@@ -31,7 +31,7 @@ else
   KIBANA_CI_REPORTER_KEY=$(retry 5 vault read -field=value secret/kibana-issues/dev/kibanamachine-reporter)
   export KIBANA_CI_REPORTER_KEY
 
-  PERCY_TOKEN=$(retry 5 vault read -field=value secret/kibana-issues/dev/percy)
+  PERCY_TOKEN=$(retry 5 vault read -field=value secret/kibana-issues/dev/percy-dev)
   export PERCY_TOKEN
 
   # remove vault related secrets

x-pack/test/functional/page_objects/infra_home_page.ts

@@ -74,5 +74,14 @@ export function InfraHomePageProvider({ getService }: FtrProviderContext) {
       await testSubjects.click('configureSourceButton');
       await testSubjects.exists('sourceConfigurationFlyout');
     },
+
+    async waitForChartToLoad() {
+      await retry.try(async () => {
+        const renderComplete = await find.byCssSelector('[data-ech-render-complete="true"]');
+        if (!renderComplete) {
+          throw new Error('Chart did not render');
+        }
+      });
+    },
   };
 }

x-pack/test/visual_regression/tests/infra/index.js

@@ -7,7 +7,7 @@
 export default function ({ loadTestFile, getService }) {
   const browser = getService('browser');
 
-  describe.skip('InfraUI Visual Regression', function () {
+  describe('InfraUI Visual Regression', function () {
     before(async () => {
       await browser.setWindowSize(1600, 1000);
     });

x-pack/test/visual_regression/tests/infra/saved_views.js

@@ -7,24 +7,31 @@ import { DATES } from '../../../functional/apps/infra/constants';
 const DATE_WITH_DATA = DATES.metricsAndLogs.hosts.withData;
 
 export default function ({ getPageObjects, getService }) {
-  const PageObjects = getPageObjects(['common', 'infraHome', 'infraMetricExplorer']);
+  const PageObjects = getPageObjects(['common', 'header', 'infraHome', 'infraMetricExplorer', 'timePicker']);
   const visualTesting = getService('visualTesting');
   const esArchiver = getService('esArchiver');
+  const find = getService('find');
 
   describe('saved views', () => {
     before(() => esArchiver.load('infra/metrics_and_logs'));
     after(() => esArchiver.unload('infra/metrics_and_logs'));
-    describe('Inverntory Test save functionality', () => {
-      it('should have save and load controls', async () => {
+
+    describe('Inventory Test save functionality', () => {
+      before(async function () {
         await PageObjects.common.navigateToApp('infraOps');
         await PageObjects.infraHome.goToTime(DATE_WITH_DATA);
+        await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
+      });
+
+      it('should have save and load controls', async () => {
         await PageObjects.infraHome.getSaveViewButton();
         await PageObjects.infraHome.getLoadViewsButton();
         await visualTesting.snapshot();
       });
 
       it('should open flyout list', async () => {
         await PageObjects.infraHome.openSaveViewsFlyout();
+        await find.waitForDeletedByCssSelector('.euiBasicTable-loading', 5000);
         await visualTesting.snapshot();
         await PageObjects.infraHome.closeSavedViewFlyout();
       });
@@ -36,26 +43,38 @@ export default function ({ getPageObjects, getService }) {
 
       it('should be able to enter a view name', async () => {
         await PageObjects.infraHome.openEnterViewNameAndSave();
+        await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
         await visualTesting.snapshot();
       });
 
       it('should see a saved view in list', async () => {
         await PageObjects.infraHome.openSaveViewsFlyout();
+        await find.waitForDeletedByCssSelector('.euiBasicTable-loading', 5000);
         await visualTesting.snapshot();
       });
     });
 
     describe('Metric Explorer Test save functionality', () => {
-      it('should have save and load controls', async () => {
+      const fromTime = 'Oct 16, 2018 @ 00:00:00.000';
+      const toTime =   'Oct 18, 2018 @ 00:00:00.000';
+
+      before(async function () {
         await PageObjects.common.navigateToApp('infraOps');
         await PageObjects.infraHome.goToMetricExplorer();
+        await PageObjects.timePicker.setAbsoluteRange(fromTime, toTime);
+        await PageObjects.header.awaitGlobalLoadingIndicatorHidden();
+        await PageObjects.infraHome.waitForChartToLoad();
+      });
+
+      it('should have save and load controls', async () => {
         await PageObjects.infraMetricExplorer.getSaveViewButton();
         await PageObjects.infraMetricExplorer.getLoadViewsButton();
         await visualTesting.snapshot();
       });
 
       it('should open flyout list', async () => {
         await PageObjects.infraMetricExplorer.openSaveViewsFlyout();
+        await find.waitForDeletedByCssSelector('.euiBasicTable-loading', 5000);
         await visualTesting.snapshot();
         await PageObjects.infraMetricExplorer.closeSavedViewFlyout();
       });
@@ -72,6 +91,7 @@ export default function ({ getPageObjects, getService }) {
 
       it('should see a saved view in list', async () => {
         await PageObjects.infraMetricExplorer.openSaveViewsFlyout();
+        await find.waitForDeletedByCssSelector('.euiBasicTable-loading', 5000);
         await visualTesting.snapshot();
       });
     });