Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable infra visual tests #51216

Closed
wants to merge 6 commits into from
Closed

Re-enable infra visual tests #51216

wants to merge 6 commits into from

Conversation

liza-mae
Copy link
Contributor

@liza-mae liza-mae commented Nov 20, 2019 •
edited
Loading

Unskip infra visual tests, added some waits for loading indicators and setting time picker to keep chart fixed.

Addresses failures in: https://percy.io/elastic/kibana-dev/builds/2814861

@liza-mae liza-mae requested a review from phillipb November 20, 2019 19:20
@liza-mae liza-mae added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.6.0 labels Nov 20, 2019
@liza-mae liza-mae self-assigned this Nov 20, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae liza-mae requested a review from a team as a code owner November 20, 2019 23:24
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

mistic
mistic approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes for the operations team code owners LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@LeeDr LeeDr added v7.7.0 and removed v7.6.0 labels Feb 4, 2020
@cachedout
Copy link
Contributor

cachedout commented Mar 24, 2020 •
edited
Loading

Hi @liza-mae . I am helping to triage some old issues for @elastic/observablt-robots and this one was in the list of priorities given to us by the Logs and Metrics UI team. Is there any way we can assist in getting this merged?

@liza-mae
Copy link
Contributor Author

Hi @cachedout thanks! I stopped working on it when we disabled visual testing on PRs and we still have not yet re-enabled them see #52026 I have a meeting later this week to discuss with Spencer the status and I will bring up what to do with this PR and yes I may reach out to get some help in closing out :) I will circle back.

@cachedout
Copy link
Contributor

Hi @liza-mae. Just following up here to see if there were any results from the meeting last week. Thanks!

@liza-mae
Copy link
Contributor Author

liza-mae commented Apr 1, 2020 •
edited
Loading

Thanks @cachedout for checking in. Yes looks like we have moved the target date for visual baselines from 7.7 to 7.8 which is still a couple months away.

I can work to see if we can do this for release testing only and get this PR merged, so I would like to circle in @mdelapenya for his opinion also, maybe we can work together to come up with something or we wait for visual baselines to be available on PRs for Kibana repo.

Thoughts?

@spalger spalger added v7.7.1 and removed v7.7.0 labels May 14, 2020
@liza-mae liza-mae removed the v7.7.1 label Jul 3, 2020
@liza-mae
Copy link
Contributor Author

OOD

@liza-mae liza-mae closed this Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

@phillipb phillipb Awaiting requested review from phillipb

Assignees

@liza-mae liza-mae

Labels
Feature:Visual Testing release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liza-mae @elasticmachine @cachedout @mistic @spalger @LeeDr