[code] Add a config option to enable the developing language servers. #29319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
spacedragon
approved these changes
Jan 25, 2019
movie-travel-code
force-pushed
the
DisableGo
branch
from
8e0ba0b to
9880c61
Compare
That makes sense, thanks! For now, we can enable the developing language servers only in development mode. |
💔 Build Failed |
|
@zfy0701 ping. |
zfy0701
approved these changes
Jan 29, 2019
Define a global variable, `LanguageServersDeveloping[]`, to store the developing language servers. And push them into `LanguageServers[]` in development mode by default.
movie-travel-code
force-pushed
the
DisableGo
branch
from
9880c61 to
b551432
Compare
💔 Build Failed |
|
nice! |
|
jenkins, test this |
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key point of the disable logic for the developing language servers is that we use another global variable, i.e.
LanguageServersDeveloping, to store the language servers under developing.If you want to enable the developing language servers, you can add the enable options in
kibana.yml, likexpack.code.enableDevelopingLangServers: ['go']. And we will move the corresponding language servers into theLanguageServersarray.