Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] WIP: Implement a go language server launcher at external mode. #29168

Merged

Conversation

movie-travel-code
Copy link

This is the initialization commit for the go language server and mainly has
two parts:

  • Add go_launcher.ts, which is mainly borrowed from
    java_launcher.ts;
  • Add the disable control for go language server.

Since there is no go language server implementation yet, we can only
test it in detach mode.

@movie-travel-code
Copy link
Author

@WangQianliang In order not to break the exists feature, I made a little tweak about project_settings.tsx. Please help me review it!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@movie-travel-code
Copy link
Author

To be noted, this PR depends on #29319

@elasticmachine
Copy link
Contributor

💔 Build Failed

@zfy0701 zfy0701 requested a review from Poytr1 January 29, 2019 01:39
@zfy0701
Copy link
Contributor

zfy0701 commented Jan 29, 2019

@Poytr1 could you do the code view as well

Copy link
Contributor

@Poytr1 Poytr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

This is the initialization commit for go language server. And
`go_launcher.ts` is mainly borrowed from `java_launcher.ts`
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@movie-travel-code movie-travel-code merged commit 360fa7d into elastic:feature/merge-code Feb 1, 2019
@movie-travel-code movie-travel-code deleted the develop branch February 1, 2019 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants