-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code] WIP: Implement a go language server launcher at external mode. #29168
Merged
movie-travel-code
merged 1 commit into
elastic:feature/merge-code
from
movie-travel-code:develop
Feb 1, 2019
Merged
[code] WIP: Implement a go language server launcher at external mode. #29168
movie-travel-code
merged 1 commit into
elastic:feature/merge-code
from
movie-travel-code:develop
Feb 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@WangQianliang In order not to break the exists feature, I made a little tweak about |
💔 Build Failed |
8abe957
to
c89a66b
Compare
To be noted, this PR depends on #29319 |
💔 Build Failed |
@Poytr1 could you do the code view as well |
Poytr1
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c89a66b
to
7ef0f7a
Compare
💔 Build Failed |
7ef0f7a
to
4bc17b9
Compare
💔 Build Failed |
4bc17b9
to
a1632d5
Compare
💔 Build Failed |
This is the initialization commit for go language server. And `go_launcher.ts` is mainly borrowed from `java_launcher.ts`
a1632d5
to
b6a4e61
Compare
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initialization commit for the go language server and mainly has
two parts:
go_launcher.ts
, which is mainly borrowed fromjava_launcher.ts
;Since there is no go language server implementation yet, we can only
test it in detach mode.