[Logs UI] Allow editing of non-resolving log views #210633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
bug
weltenwort
commented
Feb 11, 2025
|
|
||
| // If we didn't remove the item from the cache here the subsequent call to | ||
| // create would not have any effect | ||
| dataViewsService.clearInstanceCache(dataViewId); |
There was a problem hiding this comment.
I discovered this problem while testing 🤷♂️
weltenwort
commented
Feb 11, 2025
weltenwort
commented
Feb 11, 2025
| } | ||
| }; | ||
|
|
||
| const LogsSettingsPageContent = ({ |
There was a problem hiding this comment.
Just split the components for better readablility.
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
weltenwort
added
release_note:fix
backport:skip
|
@weltenwort should this be merged into 8.17 and 8.18 too? |
|
I think that would make sense |
tonyghiani
approved these changes
Feb 13, 2025
Comment on lines
+248
to
+265
| <EuiCallOut title={logIndicesMissingTitle} color="warning" iconType="warning"> | ||
| {logViewStatus.reason === 'noShardsFound' ? ( | ||
| <FormattedMessage | ||
| id="xpack.infra.sourceConfiguration.logIndicesMissingMessage.noShardsFound" | ||
| defaultMessage="No shards found for the specified indices." | ||
| /> | ||
| ) : logViewStatus.reason === 'noIndicesFound' ? ( | ||
| <FormattedMessage | ||
| id="xpack.infra.sourceConfiguration.logIndicesMissingMessage.noIndicesFound" | ||
| defaultMessage="No indices found for the specified pattern." | ||
| /> | ||
| ) : logViewStatus.reason === 'remoteClusterNotFound' ? ( | ||
| <FormattedMessage | ||
| id="xpack.infra.sourceConfiguration.logIndicesMissingMessage.remoteClusterNotFound" | ||
| defaultMessage="At least one remote cluster was not found." | ||
| /> | ||
| ) : null} | ||
| </EuiCallOut> |
There was a problem hiding this comment.
I'll defer to @mdbirnstiehl any suggestion on these copies 😄
...ons/observability/plugins/infra/public/pages/logs/settings/source_configuration_settings.tsx
Outdated
Show resolved
Hide resolved
...ons/observability/plugins/infra/public/pages/logs/settings/source_configuration_settings.tsx
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
cc @weltenwort |
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Feb 14, 2025
This changes the settings page of the Logs UI such that it allows editing of log view settings even if the resolution or status check failed. This allows recovery from various situations that were previously only recoverable by resetting the log view completely. (cherry picked from commit 41cd657)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Feb 14, 2025
This changes the settings page of the Logs UI such that it allows editing of log view settings even if the resolution or status check failed. This allows recovery from various situations that were previously only recoverable by resetting the log view completely. (cherry picked from commit 41cd657) # Conflicts: # x-pack/plugins/observability_solution/infra/public/pages/logs/settings/indices_configuration_panel.tsx
weltenwort
added a commit
that referenced
this pull request
Feb 15, 2025
…211236) # Backport This will backport the following commits from `8.x` to `8.18`: - [[Logs UI] Allow editing of non-resolving log views (#210633)](#210633) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Felix Stürmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-14T14:55:17Z","message":"[Logs UI] Allow editing of non-resolving log views (#210633)\n\nThis changes the settings page of the Logs UI such that it allows editing of log view settings even if the resolution or status check failed. This allows recovery from various situations that were previously only recoverable by resetting the log view completely.","sha":"41cd657811bd1c00ac15860268c018d4d80085ac","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Logs UI","backport:skip","Team:obs-ux-logs","v8.18.0","v8.17.3"],"title":"[Logs UI] Allow editing of non-resolving log views","number":210633,"url":"https://github.com/elastic/kibana/pull/210633","mergeCommit":{"message":"[Logs UI] Allow editing of non-resolving log views (#210633)\n\nThis changes the settings page of the Logs UI such that it allows editing of log view settings even if the resolution or status check failed. This allows recovery from various situations that were previously only recoverable by resetting the log view completely.","sha":"41cd657811bd1c00ac15860268c018d4d80085ac"}},"sourceBranch":"8.x","suggestedTargetBranches":["8.18","8.17"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
weltenwort
added a commit
that referenced
this pull request
Feb 15, 2025
…211242) # Backport This will backport the following commits from `8.x` to `8.17`: - [[Logs UI] Allow editing of non-resolving log views (#210633)](#210633) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Felix Stürmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-14T14:55:17Z","message":"[Logs UI] Allow editing of non-resolving log views (#210633)\n\nThis changes the settings page of the Logs UI such that it allows editing of log view settings even if the resolution or status check failed. This allows recovery from various situations that were previously only recoverable by resetting the log view completely.","sha":"41cd657811bd1c00ac15860268c018d4d80085ac","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Logs UI","backport:skip","Team:obs-ux-logs","v8.18.0","v8.17.3"],"title":"[Logs UI] Allow editing of non-resolving log views","number":210633,"url":"https://github.com/elastic/kibana/pull/210633","mergeCommit":{"message":"[Logs UI] Allow editing of non-resolving log views (#210633)\n\nThis changes the settings page of the Logs UI such that it allows editing of log view settings even if the resolution or status check failed. This allows recovery from various situations that were previously only recoverable by resetting the log view completely.","sha":"41cd657811bd1c00ac15860268c018d4d80085ac"}},"sourceBranch":"8.x","suggestedTargetBranches":["8.18","8.17"],"targetPullRequestStates":[{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This changes the settings page of the Logs UI such that it allows editing of log view settings even if the resolution or status check failed. This allows recovery from various situations that were previously only recoverable by resetting the log view completely.
🎨 Previews
🕵️♀️ Review notes