Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Improve error handling when using undefined remote cluster in source settings #125496

Closed
miltonhultgren opened this issue Feb 14, 2022 · 11 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:obs-ux-logs Observability Logs User Experience Team

Comments

@miltonhultgren
Copy link
Contributor

miltonhultgren commented Feb 14, 2022

📓 Summary

🚫 Blocked until #159128 is implemented.

The current implementation for the Logs UI setting page doesn't work well when a user configures an invalid index pattern, not handling properly a failing response (HTTP status 500) from the server:

[2022-02-14T12:33:41.213+00:00][ERROR][http] ResponseError: [object Object]: security_exception: [no_such_remote_cluster_exception] Reason: no such remote cluster: [remote_cluster]

👣 Reproduction steps

  1. Enter the Logs UI Settings page.
  2. Fill in an index name pattern that includes a remote cluster that is not configured, like unknown_remote:metricbeat-*
  3. Save the settings and reload the page

✔️ Acceptance criteria

  1. No Logs UI page should fail to load due to a misconfigured index source
  2. When saving the settings, warnings should be shown if there is an unknown remote cluster being used
  3. The error in Logs UI should not include the raw error, instead we should display a user-friendly message about what is wrong in the config
@miltonhultgren miltonhultgren added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@pmeresanu85 pmeresanu85 added this to the ER Archive milestone Aug 31, 2022
@pmeresanu85
Copy link

@smith I created a new Milestone label to tag all ERs which would be candidates for archiving.
Archiving doesn't mean the idea is rejected, it just means we shouldn't actively pursue this idea.

@tonyghiani
Copy link
Contributor

Related to #144882

@smith smith removed the Feature:Metrics UI Metrics UI feature label May 8, 2023
@tonyghiani tonyghiani changed the title [Metrics UI][Logs UI] Improve error handling when using undefined remote cluster in source settings [Logs UI] Improve error handling when using undefined remote cluster in source settings Jun 1, 2023
@tonyghiani
Copy link
Contributor

To gracefully handle this issue where a name pattern is not available or unreachable, we can apply the same behaviour implemented for the Metrics setting for the same scenario, solved with this PR.

@mohamedhamed-ahmed mohamedhamed-ahmed self-assigned this Jun 19, 2023
@mohamedhamed-ahmed mohamedhamed-ahmed removed their assignment Jul 27, 2023
@sophiec20 sophiec20 removed this from the ER Archive milestone Aug 4, 2023
@gbamparop gbamparop added Team:obs-ux-logs Observability Logs User Experience Team and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 9, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 9, 2023
@achyutjhunjhunwala
Copy link
Contributor

Anyone picking this issue, the only pending issue here is with the Logs Setting page

@tonyghiani
Copy link
Contributor

I've reworded the issue to be correctly scoped for the Logs UI settings. The suggested approach to implement a solution is still valid.

@gbamparop
Copy link
Contributor

Related to #180936

@gui-elastic gui-elastic added the bug Fixes for quality problems that affect the customer experience label Jan 17, 2025
@gui-elastic
Copy link
Member

@gbamparop Is it possible to assign someone to this issue and do we have any ETA to fix it?

@gbamparop
Copy link
Contributor

@gui-elastic configuring log sources with index patterns and data views through the log settings page is now deprecated in favour of the relevant Kibana advanced setting. This setting is visible in the log settings page but can only be changed from Stack Management.

Image

Both the log settings and log stream pages will be removed in 9.0 (#203996, #204115) where this will no longer be an issue.

However, the issue is present in 8.17 when configuring the log sources through Kibana advanced settings and navigate to the log settings page.

Screen.Recording.2025-01-23.at.12.40.45.mov

A workaround is to update the Kibana advanced setting by removing the remote cluster that doesn't exist. Does this work for you?

We could investigate potential fixes and consider a fix for 8.x.

@weltenwort
Copy link
Member

  • ✅ done in 8.x
  • 🔙 backported to 8.18
  • 🔙 backported to 8.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Development

No branches or pull requests