[Ownership] Assign sample data to core team #200142
Conversation
wayneseymour
added
release_note:skip
|
👋 @wayneseymour was this intended to be assigned to the docs team? |
Indeed, per this pr |
|
I think since these functions are used beyond just the screenshot automation, it's better to have a QA team own that directory. |
| @@ -1095,6 +1095,7 @@ x-pack/test_serverless/api_integration/test_suites/common/platform_security @ela | |||
| src/plugins/discover/public/context_awareness/profile_providers/security @elastic/kibana-data-discovery @elastic/security-threat-hunting-investigations | |||
|
|
|||
| # Platform Docs | |||
| /x-pack/test/functional/services/sample_data @elastic/platform-docs | |||
There was a problem hiding this comment.
The sample data functionality is implemented in the home plugin which is owned by the @elastic/kibana-core team. So I think it would make sense that this teams also owns the corresponding test helpers that are using the APIs provided by that plugin, following our principle that tests / test helpers should be close to the functionality they testing, which starts with code ownership.
There was a problem hiding this comment.
@wayneseymour , my apologies, I believe we need to update this to @elastic/appex-sharedux ... I see we are listed as the owners in home/kibana.jsonc but I think this is no longer maintained by our team.
There was a problem hiding this comment.
Does that mean that home/kibana.jsonc should be updated to relfect this as well? It seems so to me.
There was a problem hiding this comment.
fyi: follow-up / fix pr
|
@elasticmachine merge upstream |
wayneseymour
changed the title
💚 Build Succeeded
Metrics [docs]
|
## Summary Assign test files to platform docs team Contributes to: elastic#192979 Co-authored-by: Elastic Machine <[email protected]>
## Summary Assign home plugin and helper. This pr is a follow up to a wrongly assigned entry within #200142 Contributes to: #192979 --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Assign home plugin and helper. This pr is a follow up to a wrongly assigned entry within elastic#200142 Contributes to: elastic#192979 --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Assign test files to platform docs team Contributes to: elastic#192979 Co-authored-by: Elastic Machine <[email protected]>
## Summary Assign home plugin and helper. This pr is a follow up to a wrongly assigned entry within elastic#200142 Contributes to: elastic#192979 --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Assign test files to platform docs team
Contributes to: #192979