Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Automate connector-listing.png #143605

Merged
merged 21 commits into from
Nov 18, 2022
Merged

[DOCS] Automate connector-listing.png #143605

merged 21 commits into from
Nov 18, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 18, 2022 •
edited by kibanamachine
Loading

Summary

Relates to #143809

This PR adds automated screenshots for alerting documentation. In particular, it automates the first screenshot from https://www.elastic.co/guide/en/kibana/master/action-types.html#connector-management

@lcawl lcawl added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs v8.6.0 v8.5.1 labels Oct 18, 2022
@lcawl lcawl force-pushed the alerting-screenshot1 branch from e878efa to e748a14 Compare October 21, 2022 01:07
@lcawl lcawl marked this pull request as ready for review October 21, 2022 01:08
@lcawl lcawl requested review from a team as code owners October 21, 2022 01:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl requested a review from pheyos October 21, 2022 01:08
@lcawl lcawl changed the title [DOCS] Add stack_alerting screenshot tests [DOCS] Automate connector-listing.png Oct 21, 2022
@lcawl lcawl added release_note:enhancement release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Oct 21, 2022
@lcawl lcawl marked this pull request as draft October 31, 2022 15:29
@lcawl lcawl marked this pull request as ready for review November 4, 2022 23:06
pheyos
pheyos approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl requested a review from a team as a code owner November 11, 2022 01:40
@lcawl lcawl enabled auto-merge (squash) November 15, 2022 01:22
@lcawl lcawl force-pushed the alerting-screenshot1 branch from c21ee6b to f9d0da3 Compare November 15, 2022 15:57
@lcawl lcawl marked this pull request as draft November 17, 2022 00:45
auto-merge was automatically disabled November 17, 2022 00:45

Pull request was converted to draft

@lcawl lcawl marked this pull request as ready for review November 17, 2022 16:43
jonathan-buttner
jonathan-buttner reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! One other cleanup request, to remove supertest as a parameter in a few places.

x-pack/test/functional/services/sample_data/test_resources.ts
@@ -0,0 +1,37 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/general.ts
@@ -78,6 +78,7 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
const createdAction = await createSlackConnector({
name: connectorName,
supertest,
getService,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up from my previous comment about removing supertest as a prop, we'll just need to carry those changes through to here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed in bc960b34ee5c4c7b76fa0b8934a00725c4aca863

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry what I meant was that line 80 in this file is no longer needed either. createSlackConnector doesn't use supertest anymore.

@lcawl lcawl force-pushed the alerting-screenshot1 branch from bc960b3 to e821310 Compare November 17, 2022 18:06
@lcawl lcawl added the v8.7.0 label Nov 17, 2022
@lcawl lcawl enabled auto-merge (squash) November 17, 2022 18:07
jonathan-buttner
jonathan-buttner reviewed Nov 17, 2022
View reviewed changes
x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/connectors/general.ts
@@ -78,6 +78,7 @@ export default ({ getPageObjects, getPageObject, getService }: FtrProviderContex
const createdAction = await createSlackConnector({
name: connectorName,
supertest,
getService,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry what I meant was that line 80 in this file is no longer needed either. createSlackConnector doesn't use supertest anymore.

jonathan-buttner
jonathan-buttner approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚢

@lcawl lcawl merged commit 31ca644 into elastic:main Nov 18, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 442 448 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 519 525 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine mentioned this pull request Nov 18, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 18, 2022
@lcawl
[DOCS] Automate connector-listing.png (elastic#143605)
029377b 
Co-authored-by: Robert Oskamp <[email protected]>
(cherry picked from commit 31ca644)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.5 Backport failed because of merge conflicts
✅ 8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 143605

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl deleted the alerting-screenshot1 branch November 18, 2022 01:33
lcawl added a commit that referenced this pull request Nov 18, 2022
@kibanamachine @lcawl
[8.6] [DOCS] Automate connector-listing.png (#143605) (#145659)
a8164ed 
# Backport

This will backport the following commits from `main` to `8.6`:
- [[DOCS] Automate connector-listing.png
(#143605)](#143605)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-18T01:08:41Z","message":"[DOCS]
Automate connector-listing.png (#143605)\n\nCo-authored-by: Robert
Oskamp
<[email protected]>","sha":"31ca6447332e52e502f0ed3645ebb02f054807c7","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","v8.6.0","v8.5.1","v8.7.0"],"number":143605,"url":"https://github.com/elastic/kibana/pull/143605","mergeCommit":{"message":"[DOCS]
Automate connector-listing.png (#143605)\n\nCo-authored-by: Robert
Oskamp
<[email protected]>","sha":"31ca6447332e52e502f0ed3645ebb02f054807c7"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.5"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.5","label":"v8.5.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/143605","number":143605,"mergeCommit":{"message":"[DOCS]
Automate connector-listing.png (#143605)\n\nCo-authored-by: Robert
Oskamp
<[email protected]>","sha":"31ca6447332e52e502f0ed3645ebb02f054807c7"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit to lcawl/kibana that referenced this pull request Nov 18, 2022
@lcawl
[DOCS] Automate connector-listing.png (elastic#143605)
29c8c4e 
Co-authored-by: Robert Oskamp <[email protected]>
(cherry picked from commit 31ca644)
@lcawl lcawl mentioned this pull request Nov 18, 2022
Merged
@lcawl
Copy link
Contributor Author

lcawl commented Nov 18, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl added the v8.5.2 label Nov 18, 2022
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 22, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

lcawl added a commit that referenced this pull request Nov 23, 2022
@lcawl
[8.5] [DOCS] Automate connector-listing.png (#143605) (#145661)
b3ea3bf
@kibanamachine kibanamachine added v8.5.3 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 23, 2022
@wayneseymour wayneseymour mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees
No one assigned
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.5.2 v8.5.3 v8.6.0 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @elasticmachine @kibana-ci @kibanamachine @pheyos @jonathan-buttner